You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "suyanhanx (via GitHub)" <gi...@apache.org> on 2024/01/28 10:00:25 UTC
[PR] chore(bindings/dotnet): build os detect [opendal]
suyanhanx opened a new pull request, #4085:
URL: https://github.com/apache/opendal/pull/4085
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(bindings/dotnet): build os detect [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #4085:
URL: https://github.com/apache/opendal/pull/4085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(bindings/dotnet): build os detect [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #4085:
URL: https://github.com/apache/opendal/pull/4085#discussion_r1468808442
##########
bindings/dotnet/DotOpenDAL/DotOpenDAL.csproj:
##########
@@ -17,10 +17,20 @@
<Nullable>enable</Nullable>
</PropertyGroup>
- <ItemGroup>
+ <ItemGroup Condition="$([System.Runtime.InteropServices.RuntimeInformation]::RuntimeIdentifier.StartsWith('osx'))">
+ <None Include="../target/debug/libopendal_dotnet.dylib">
+ <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+ </None>
+ </ItemGroup>
+ <ItemGroup Condition="$([System.Runtime.InteropServices.RuntimeInformation]::RuntimeIdentifier.StartsWith('linux'))">
<None Include="../target/debug/libopendal_dotnet.so">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
</ItemGroup>
+ <ItemGroup Condition="$([System.Runtime.InteropServices.RuntimeInformation]::RuntimeIdentifier.StartsWith('linux'))">
Review Comment:
This should be `windows`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(bindings/dotnet): build os detect [opendal]
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on code in PR #4085:
URL: https://github.com/apache/opendal/pull/4085#discussion_r1468811732
##########
bindings/dotnet/DotOpenDAL/DotOpenDAL.csproj:
##########
@@ -17,10 +17,20 @@
<Nullable>enable</Nullable>
</PropertyGroup>
- <ItemGroup>
+ <ItemGroup Condition="$([System.Runtime.InteropServices.RuntimeInformation]::RuntimeIdentifier.StartsWith('osx'))">
+ <None Include="../target/debug/libopendal_dotnet.dylib">
Review Comment:
Let me give a try.
##########
bindings/dotnet/DotOpenDAL/DotOpenDAL.csproj:
##########
@@ -17,10 +17,20 @@
<Nullable>enable</Nullable>
</PropertyGroup>
- <ItemGroup>
+ <ItemGroup Condition="$([System.Runtime.InteropServices.RuntimeInformation]::RuntimeIdentifier.StartsWith('osx'))">
+ <None Include="../target/debug/libopendal_dotnet.dylib">
Review Comment:
Let me give it a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(bindings/dotnet): build os detect [opendal]
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on code in PR #4085:
URL: https://github.com/apache/opendal/pull/4085#discussion_r1468808528
##########
bindings/dotnet/DotOpenDAL/DotOpenDAL.csproj:
##########
@@ -17,10 +17,20 @@
<Nullable>enable</Nullable>
</PropertyGroup>
- <ItemGroup>
+ <ItemGroup Condition="$([System.Runtime.InteropServices.RuntimeInformation]::RuntimeIdentifier.StartsWith('osx'))">
+ <None Include="../target/debug/libopendal_dotnet.dylib">
+ <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+ </None>
+ </ItemGroup>
+ <ItemGroup Condition="$([System.Runtime.InteropServices.RuntimeInformation]::RuntimeIdentifier.StartsWith('linux'))">
<None Include="../target/debug/libopendal_dotnet.so">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
</ItemGroup>
+ <ItemGroup Condition="$([System.Runtime.InteropServices.RuntimeInformation]::RuntimeIdentifier.StartsWith('linux'))">
Review Comment:
Oh, my bad
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(bindings/dotnet): build os detect [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #4085:
URL: https://github.com/apache/opendal/pull/4085#discussion_r1468811510
##########
bindings/dotnet/DotOpenDAL/DotOpenDAL.csproj:
##########
@@ -17,10 +17,20 @@
<Nullable>enable</Nullable>
</PropertyGroup>
- <ItemGroup>
+ <ItemGroup Condition="$([System.Runtime.InteropServices.RuntimeInformation]::RuntimeIdentifier.StartsWith('osx'))">
+ <None Include="../target/debug/libopendal_dotnet.dylib">
Review Comment:
By the way, can we copy `../target/debug/libopendal_dotnet.*` instead of writing cases for every platform?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(bindings/dotnet): build os detect [opendal]
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on code in PR #4085:
URL: https://github.com/apache/opendal/pull/4085#discussion_r1468845589
##########
bindings/dotnet/DotOpenDAL/DotOpenDAL.csproj:
##########
@@ -17,10 +17,20 @@
<Nullable>enable</Nullable>
</PropertyGroup>
- <ItemGroup>
+ <ItemGroup Condition="$([System.Runtime.InteropServices.RuntimeInformation]::RuntimeIdentifier.StartsWith('osx'))">
+ <None Include="../target/debug/libopendal_dotnet.dylib">
Review Comment:
It works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org