[GitHub] [skywalking-query-protocol] wu-sheng commented on a diff in pull request #110: Add isEmptyValue flag to indicate clear meaning for value

["wu-sheng (via GitHub)" <gi...@apache.org>]

wu-sheng commented on code in PR #110:
URL: https://github.com/apache/skywalking-query-protocol/pull/110#discussion_r1142037090


##########
metric.graphqls:
##########
@@ -50,6 +50,8 @@ type KVInt {
     # 1. If ask for cpm metric, the unit and result should be count.
     # 2. If ask for response time (p99 or avg), the unit should be millisecond.
     value: Long!
+    # Since 9.5.0, isEmptyValue indicates whether value == 0 represents actually zero(false, default) or no data(true).
+    isEmptyValue: Boolean!

Review Comment:
   You could only use it when the value is `0`. But from a server-side perspective, it must be returned from a GraphQL perspective. I am not sure what do you expect about `only`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org