You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/01/04 15:55:10 UTC
[GitHub] [mynewt-nimble] wnnwoo opened a new pull request #717: Add more
detail about the MACRO description
wnnwoo opened a new pull request #717: Add more detail about the MACRO description
URL: https://github.com/apache/mynewt-nimble/pull/717
1. Add LE Uncoded PHY 1M
In the formula: IFS + SCAN_REQ + IFS + SCAN_RSP = 150 + 176 + 150 + 376.
SCAN_REQ are about 176u, it means 176 bit = 1B(Preamble) + 4B(AA) + 14B(Payload) + 3B(CRC)=22B=22*8bits = 176bits.
this formula should be for LE Uncoded PHY 1M.
for 2M PHY, the preamble is 2B (Core Spec v5.1 p2691), the result is not the same as 1M.
2. Suggest to use CONN_IND as the Core Spec v5.1 p2706.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #717:
Add more detail about the MACRO description
Posted by GitBox <gi...@apache.org>.
sjanc commented on a change in pull request #717: Add more detail about the MACRO description
URL: https://github.com/apache/mynewt-nimble/pull/717#discussion_r368414014
##########
File path: nimble/controller/include/controller/ble_ll_sched.h
##########
@@ -31,13 +31,13 @@ extern "C" {
/*
* Worst case time needed for scheduled advertising item. This is the longest
* possible time to receive a scan request and send a scan response (with the
- * appropriate IFS time between them). This number is calculated using the
+ * appropriate IFS time between them) on LE Uncoded PHY 1M. This number is calculated using the
Review comment:
Please update PR with comment changes we discussed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] wnnwoo commented on a change in pull request #717:
Add more detail about the MACRO description
Posted by GitBox <gi...@apache.org>.
wnnwoo commented on a change in pull request #717: Add more detail about the MACRO description
URL: https://github.com/apache/mynewt-nimble/pull/717#discussion_r366935748
##########
File path: nimble/controller/include/controller/ble_ll_sched.h
##########
@@ -31,13 +31,13 @@ extern "C" {
/*
* Worst case time needed for scheduled advertising item. This is the longest
* possible time to receive a scan request and send a scan response (with the
- * appropriate IFS time between them). This number is calculated using the
+ * appropriate IFS time between them) on LE Uncoded PHY 1M. This number is calculated using the
Review comment:
then what will be the next step?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #717:
Add more detail about the MACRO description
Posted by GitBox <gi...@apache.org>.
sjanc commented on a change in pull request #717: Add more detail about the MACRO description
URL: https://github.com/apache/mynewt-nimble/pull/717#discussion_r363681800
##########
File path: nimble/controller/include/controller/ble_ll_sched.h
##########
@@ -31,13 +31,13 @@ extern "C" {
/*
* Worst case time needed for scheduled advertising item. This is the longest
* possible time to receive a scan request and send a scan response (with the
- * appropriate IFS time between them). This number is calculated using the
+ * appropriate IFS time between them) on LE Uncoded PHY 1M. This number is calculated using the
Review comment:
this is about legacy PDUs and those are on 1M by definition so not sure if this clear anything
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #717:
Add more detail about the MACRO description
Posted by GitBox <gi...@apache.org>.
sjanc commented on a change in pull request #717: Add more detail about the MACRO description
URL: https://github.com/apache/mynewt-nimble/pull/717#discussion_r365700276
##########
File path: nimble/controller/include/controller/ble_ll_sched.h
##########
@@ -31,13 +31,13 @@ extern "C" {
/*
* Worst case time needed for scheduled advertising item. This is the longest
* possible time to receive a scan request and send a scan response (with the
- * appropriate IFS time between them). This number is calculated using the
+ * appropriate IFS time between them) on LE Uncoded PHY 1M. This number is calculated using the
Review comment:
Yeap, I'm fine with emphasizing that this is for legacy PDUs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] wnnwoo commented on a change in pull request #717:
Add more detail about the MACRO description
Posted by GitBox <gi...@apache.org>.
wnnwoo commented on a change in pull request #717: Add more detail about the MACRO description
URL: https://github.com/apache/mynewt-nimble/pull/717#discussion_r365496150
##########
File path: nimble/controller/include/controller/ble_ll_sched.h
##########
@@ -31,13 +31,13 @@ extern "C" {
/*
* Worst case time needed for scheduled advertising item. This is the longest
* possible time to receive a scan request and send a scan response (with the
- * appropriate IFS time between them). This number is calculated using the
+ * appropriate IFS time between them) on LE Uncoded PHY 1M. This number is calculated using the
Review comment:
then we should say it is legacy adv obviously in this sentence.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services