You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by fa...@apache.org on 2025/04/10 08:08:23 UTC
svn commit: r1924986 - in /poi/trunk/poi-ooxml/src: main/java/org/apache/poi/xssf/streaming/SheetDataWriter.java test/java/org/apache/poi/xssf/streaming/TestSheetDataWriter.java
Author: fanningpj
Date: Thu Apr 10 08:08:22 2025
New Revision: 1924986
URL: http://svn.apache.org/viewvc?rev=1924986&view=rev
Log:
[bug-69646] add tests
Modified:
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SheetDataWriter.java
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSheetDataWriter.java
Modified: poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SheetDataWriter.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SheetDataWriter.java?rev=1924986&r1=1924985&r2=1924986&view=diff
==============================================================================
--- poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SheetDataWriter.java (original)
+++ poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SheetDataWriter.java Thu Apr 10 08:08:22 2025
@@ -460,7 +460,7 @@ public class SheetDataWriter implements
try {
_out.close();
} finally {
- ret = _fd != null && _fd.delete();
+ ret = _fd == null || _fd.delete();
}
return ret;
}
Modified: poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSheetDataWriter.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSheetDataWriter.java?rev=1924986&r1=1924985&r2=1924986&view=diff
==============================================================================
--- poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSheetDataWriter.java (original)
+++ poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSheetDataWriter.java Thu Apr 10 08:08:22 2025
@@ -26,6 +26,7 @@ import static org.junit.jupiter.api.Asse
import java.io.File;
import java.io.FileInputStream;
import java.io.IOException;
+import java.io.StringWriter;
import java.nio.charset.StandardCharsets;
import org.apache.poi.util.IOUtils;
@@ -69,6 +70,7 @@ public final class TestSheetDataWriter {
IOUtils.closeQuietly(writer);
}
}
+
@Test
void testWriteNewLines() throws IOException {
SheetDataWriter writer = new SheetDataWriter();
@@ -84,4 +86,17 @@ public final class TestSheetDataWriter {
IOUtils.closeQuietly(writer);
}
}
+
+ @Test
+ void testDispose() throws IOException {
+ SheetDataWriter writer = new SheetDataWriter();
+ assertTrue(writer.dispose());
+ }
+
+ @Test
+ void testWriterDispose() throws IOException {
+ StringWriter sw = new StringWriter();
+ SheetDataWriter writer = new SheetDataWriter(sw);
+ assertTrue(writer.dispose());
+ }
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org