You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by l-dobrev <gi...@git.apache.org> on 2016/01/26 12:05:43 UTC
[GitHub] activemq-artemis pull request: Fix for ARTEMIS-362
GitHub user l-dobrev opened a pull request:
https://github.com/apache/activemq-artemis/pull/348
Fix for ARTEMIS-362
Fix for https://issues.apache.org/jira/browse/ARTEMIS-362
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/l-dobrev/activemq-artemis master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/348.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #348
----
commit 6c6a237aa276ce7411bcf241495f19d1fff877ee
Author: Lachezar Dobrev <l....@gmail.com>
Date: 2016-01-26T11:03:29Z
Fix for ARTEMIS-362
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Fix for ARTEMIS-362
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/348
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Fix for ARTEMIS-362
Posted by l-dobrev <gi...@git.apache.org>.
Github user l-dobrev commented on the pull request:
https://github.com/apache/activemq-artemis/pull/348#issuecomment-175111108
Amended.
How's that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Fix for ARTEMIS-362
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/348#issuecomment-175096224
I would like to see a description on the commit about what is being changed...
It's fairly common having to do a git log to figure out when things got broken... and having to open the JIRA to see what happened is not very practical.
I can change the commit description before merging though if you don't mind... but if you can ammend with a description such as
___
ARTEMIS-362 Only sending UDP packets bytes as needed
You can use the next lines to explain things.. etc...
_____
Looking at the website (JIRA on this case) should be an extra step to eventually look for discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Fix for ARTEMIS-362
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/348#issuecomment-175112492
much better.. thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Fix for ARTEMIS-362
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/348#issuecomment-175148138
It seems nice and clear to be merged.. but I am running the entire testsuite on my box before merging this.. .just to be safe.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---