You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by jm...@apache.org on 2017/11/14 15:56:23 UTC
samza git commit: SAMZA-1492: Add exception counter to
LocalStoreMonitor.
Repository: samza
Updated Branches:
refs/heads/master d35355aa0 -> 26dd9c14c
SAMZA-1492: Add exception counter to LocalStoreMonitor.
Add storeGCExceptionCounter to LocalStoreMonitor(as a part of LocalStoreMonitorMetrics) to enable alerts setup in an production environment.
Author: Shanthoosh Venkataraman <sv...@linkedin.com>
Reviewers: Jacob Maes <jm...@linkedin.com>
Closes #357 from shanthoosh/local_store_monitor_metrics_1
Project: http://git-wip-us.apache.org/repos/asf/samza/repo
Commit: http://git-wip-us.apache.org/repos/asf/samza/commit/26dd9c14
Tree: http://git-wip-us.apache.org/repos/asf/samza/tree/26dd9c14
Diff: http://git-wip-us.apache.org/repos/asf/samza/diff/26dd9c14
Branch: refs/heads/master
Commit: 26dd9c14c778862058ddaf8e866f8f12e77457d9
Parents: d35355a
Author: Shanthoosh Venkataraman <sv...@linkedin.com>
Authored: Tue Nov 14 07:56:13 2017 -0800
Committer: Jacob Maes <jm...@linkedin.com>
Committed: Tue Nov 14 07:56:13 2017 -0800
----------------------------------------------------------------------
.../main/java/org/apache/samza/monitor/LocalStoreMonitor.java | 1 +
.../java/org/apache/samza/monitor/LocalStoreMonitorMetrics.java | 4 ++++
2 files changed, 5 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/samza/blob/26dd9c14/samza-rest/src/main/java/org/apache/samza/monitor/LocalStoreMonitor.java
----------------------------------------------------------------------
diff --git a/samza-rest/src/main/java/org/apache/samza/monitor/LocalStoreMonitor.java b/samza-rest/src/main/java/org/apache/samza/monitor/LocalStoreMonitor.java
index 8b25636..01b8ed7 100644
--- a/samza-rest/src/main/java/org/apache/samza/monitor/LocalStoreMonitor.java
+++ b/samza-rest/src/main/java/org/apache/samza/monitor/LocalStoreMonitor.java
@@ -104,6 +104,7 @@ public class LocalStoreMonitor implements Monitor {
}
}
} catch (Exception ex) {
+ localStoreMonitorMetrics.failedStoreDeletionAttempts.inc();
if (!config.getIgnoreFailures()) {
throw ex;
}
http://git-wip-us.apache.org/repos/asf/samza/blob/26dd9c14/samza-rest/src/main/java/org/apache/samza/monitor/LocalStoreMonitorMetrics.java
----------------------------------------------------------------------
diff --git a/samza-rest/src/main/java/org/apache/samza/monitor/LocalStoreMonitorMetrics.java b/samza-rest/src/main/java/org/apache/samza/monitor/LocalStoreMonitorMetrics.java
index 204f3dd..0ff32fe 100644
--- a/samza-rest/src/main/java/org/apache/samza/monitor/LocalStoreMonitorMetrics.java
+++ b/samza-rest/src/main/java/org/apache/samza/monitor/LocalStoreMonitorMetrics.java
@@ -33,9 +33,13 @@ public class LocalStoreMonitorMetrics extends MetricsBase {
/** Total disk space cleared by the LocalStoreMonitor. */
public final Counter diskSpaceFreedInBytes;
+ /** Total number of times task store deletions have been attempted and failed. */
+ public final Counter failedStoreDeletionAttempts;
+
public LocalStoreMonitorMetrics(String prefix, MetricsRegistry registry) {
super(prefix, registry);
diskSpaceFreedInBytes = newCounter("diskSpaceFreedInBytes");
noOfDeletedTaskPartitionStores = newCounter("noOfDeletedTaskPartitionStores");
+ failedStoreDeletionAttempts = newCounter("failedStoreDeletionAttempts");
}
}