[GitHub] [airflow] XD-DENG commented on issue #5501: [AIRFLOW-4862] Allow directly using IP address as hostname

[GitBox <gi...@apache.org>]

XD-DENG commented on issue #5501: [AIRFLOW-4862] Allow directly using IP address as hostname
URL: https://github.com/apache/airflow/pull/5501#issuecomment-507618423
 
 
   Hi @ashb , I'm sorry but I think there is an issue introduced here. 
   
   ```python
   def get_host_ip_address():
       socket.gethostbyname(socket.getfqdn())
   ```
   
   I didn't explicitly return the value so this function will always return `None`. A `return` is missed here.
   I will raise another PR (with the same JIRA number maybe), and will tag you there.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services