[GitHub] [inlong] healchow commented on a diff in pull request #6701: [INLONG-6610][Manager] Support the saving and query of data report-to settings (addendum)

[GitBox <gi...@apache.org>]

healchow commented on code in PR #6701:
URL: https://github.com/apache/inlong/pull/6701#discussion_r1037677721


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/group/InlongGroupServiceImpl.java:
##########
@@ -382,6 +382,10 @@ public void updateAfterApprove(InlongGroupApproveRequest approveRequest, String
             entity.setInlongGroupId(groupId);
             entity.setInlongClusterTag(approveRequest.getInlongClusterTag());
             entity.setStatus(GroupStatus.APPROVE_PASSED.getCode());
+            if (approveRequest.getDataReportType() != null
+                    && approveRequest.getDataReportType() != entity.getDataReportType()) {

Review Comment:
   It seems that the second condition is unnecessary.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org