You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/10/30 05:52:24 UTC
[GitHub] [dubbo-go] LaurenceLiZhixin opened a new pull request #824: Ftr: Add grpc max message size config
LaurenceLiZhixin opened a new pull request #824:
URL: https://github.com/apache/dubbo-go/pull/824
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request.
-->
**What this PR does**:
增加“在配置文件中设置grpc max message size“”的功能。
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #806
**Special notes for your reviewer**:
在Service中增加标签为 max_message_size的字段，在开启grpc server时作为参数传入，并写入invoker用于暴露。
客户端拿到服务端url后会更新本地invoker，grpc client会自动调整为与服务端message_size一致。
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
NONE
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #824: Ftr: Add grpc max message size config
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #824:
URL: https://github.com/apache/dubbo-go/pull/824#discussion_r514887051
##########
File path: protocol/grpc/grpc_protocol.go
##########
@@ -18,6 +18,8 @@
package grpc
import (
Review comment:
split it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on a change in pull request #824: Ftr: Add grpc max message size config
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #824:
URL: https://github.com/apache/dubbo-go/pull/824#discussion_r514894072
##########
File path: protocol/grpc/grpc_protocol.go
##########
@@ -18,6 +18,8 @@
package grpc
import (
Review comment:
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] cityiron commented on pull request #824: Ftr: Add grpc max message size config
Posted by GitBox <gi...@apache.org>.
cityiron commented on pull request #824:
URL: https://github.com/apache/dubbo-go/pull/824#issuecomment-723443199
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] cityiron commented on a change in pull request #824: Ftr: Add grpc max message size config
Posted by GitBox <gi...@apache.org>.
cityiron commented on a change in pull request #824:
URL: https://github.com/apache/dubbo-go/pull/824#discussion_r518827386
##########
File path: common/constant/key.go
##########
@@ -25,6 +25,7 @@ const (
GROUP_KEY = "group"
VERSION_KEY = "version"
INTERFACE_KEY = "interface"
+ GRPC_MESSAGE_SIZE_KEY = "message_size"
Review comment:
@LaurenceLiZhixin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] cityiron commented on a change in pull request #824: Ftr: Add grpc max message size config
Posted by GitBox <gi...@apache.org>.
cityiron commented on a change in pull request #824:
URL: https://github.com/apache/dubbo-go/pull/824#discussion_r518811640
##########
File path: config/service_config.go
##########
@@ -73,6 +73,7 @@ type ServiceConfig struct {
Auth string `yaml:"auth" json:"auth,omitempty" property:"auth"`
ParamSign string `yaml:"param.sign" json:"param.sign,omitempty" property:"param.sign"`
Tag string `yaml:"tag" json:"tag,omitempty" property:"tag"`
+ GrpcMaxMessageSize int `default:"4" yaml:"max_message_size" json:"max_message_size,omitempty"`
Review comment:
I think other field is common field name, but GrpcMaxMessageSize mean only for grpc, so in my view MaxMessageSize is better.
##########
File path: common/constant/key.go
##########
@@ -25,6 +25,7 @@ const (
GROUP_KEY = "group"
VERSION_KEY = "version"
INTERFACE_KEY = "interface"
+ GRPC_MESSAGE_SIZE_KEY = "message_size"
Review comment:
GRPC_MESSAGE_SIZE_KEY change to MESSAGE_SIZE_KEY may be better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #824: Ftr: Add grpc max message size config
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #824:
URL: https://github.com/apache/dubbo-go/pull/824
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org