You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2017/10/03 20:24:40 UTC
Re: Review Request 60511: Added MockMetadataManager and test
concurrent prune and pull.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60511/
-----------------------------------------------------------
(Updated Oct. 3, 2017, 8:24 p.m.)
Review request for mesos, Gilbert Song and Jason Lai.
Changes
-------
Fix test due to changed error message.
Bugs: MESOS-4945
https://issues.apache.org/jira/browse/MESOS-4945
Repository: mesos
Description
-------
Added MockMetadataManager and test concurrent prune and pull.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 954da1681778878c8aff6150002e52ecb648d1bb
src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp d86afd2a6ff0bf87e624db1c99255c85068bf6ab
src/slave/containerizer/mesos/provisioner/docker/store.hpp 1cf68665d33bd40a7605d26c96fb7b618407fdd0
src/slave/containerizer/mesos/provisioner/docker/store.cpp f357710cb19aec3654b0604f7909d068eaf20095
src/tests/containerizer/provisioner_docker_tests.cpp 920be77b16178a4458d72145020c015130799ec4
Diff: https://reviews.apache.org/r/60511/diff/5/
Changes: https://reviews.apache.org/r/60511/diff/4-5/
Testing
-------
Thanks,
Zhitao Li
Re: Review Request 60511: Added MockMetadataManager and test
concurrent prune and pull.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60511/#review187017
-----------------------------------------------------------
FAIL: /usr/bin/rm: cannot remove 'C:mesos/CMakeFiles': Directory not empty
Reviews applied: `['55334', '55335', '59687', '56721', '60471', '56722', '60511']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/60511
- Mesos Reviewbot Windows
On Oct. 3, 2017, 8:24 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60511/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2017, 8:24 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jason Lai.
>
>
> Bugs: MESOS-4945
> https://issues.apache.org/jira/browse/MESOS-4945
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added MockMetadataManager and test concurrent prune and pull.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 954da1681778878c8aff6150002e52ecb648d1bb
> src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp d86afd2a6ff0bf87e624db1c99255c85068bf6ab
> src/slave/containerizer/mesos/provisioner/docker/store.hpp 1cf68665d33bd40a7605d26c96fb7b618407fdd0
> src/slave/containerizer/mesos/provisioner/docker/store.cpp f357710cb19aec3654b0604f7909d068eaf20095
> src/tests/containerizer/provisioner_docker_tests.cpp 920be77b16178a4458d72145020c015130799ec4
>
>
> Diff: https://reviews.apache.org/r/60511/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 60511: Added MockMetadataManager and test
concurrent prune and pull.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60511/#review187032
-----------------------------------------------------------
PASS: Mesos patch 60511 was successfully built and tested.
Reviews applied: `['55334', '55335', '59687', '56721', '60471', '56722', '60511']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/60511
- Mesos Reviewbot Windows
On Oct. 3, 2017, 1:24 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60511/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2017, 1:24 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jason Lai.
>
>
> Bugs: MESOS-4945
> https://issues.apache.org/jira/browse/MESOS-4945
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added MockMetadataManager and test concurrent prune and pull.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 954da1681778878c8aff6150002e52ecb648d1bb
> src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp d86afd2a6ff0bf87e624db1c99255c85068bf6ab
> src/slave/containerizer/mesos/provisioner/docker/store.hpp 1cf68665d33bd40a7605d26c96fb7b618407fdd0
> src/slave/containerizer/mesos/provisioner/docker/store.cpp f357710cb19aec3654b0604f7909d068eaf20095
> src/tests/containerizer/provisioner_docker_tests.cpp 920be77b16178a4458d72145020c015130799ec4
>
>
> Diff: https://reviews.apache.org/r/60511/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 60511: Added MockMetadataManager and test
concurrent prune and pull.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60511/#review187035
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55334, 55335, 59687, 56721, 60471, 56722, 60511]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 3, 2017, 8:24 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60511/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2017, 8:24 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jason Lai.
>
>
> Bugs: MESOS-4945
> https://issues.apache.org/jira/browse/MESOS-4945
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added MockMetadataManager and test concurrent prune and pull.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 954da1681778878c8aff6150002e52ecb648d1bb
> src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp d86afd2a6ff0bf87e624db1c99255c85068bf6ab
> src/slave/containerizer/mesos/provisioner/docker/store.hpp 1cf68665d33bd40a7605d26c96fb7b618407fdd0
> src/slave/containerizer/mesos/provisioner/docker/store.cpp f357710cb19aec3654b0604f7909d068eaf20095
> src/tests/containerizer/provisioner_docker_tests.cpp 920be77b16178a4458d72145020c015130799ec4
>
>
> Diff: https://reviews.apache.org/r/60511/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 60511: Added MockMetadataManager and test
concurrent prune and pull.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60511/#review187511
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55334, 55335, 59687, 56721, 56722, 60471, 62853, 60511]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 9, 2017, 11:21 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60511/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2017, 11:21 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jason Lai.
>
>
> Bugs: MESOS-4945
> https://issues.apache.org/jira/browse/MESOS-4945
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added MockMetadataManager and test concurrent prune and pull.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 954da1681778878c8aff6150002e52ecb648d1bb
> src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp d86afd2a6ff0bf87e624db1c99255c85068bf6ab
> src/slave/containerizer/mesos/provisioner/docker/store.hpp 1cf68665d33bd40a7605d26c96fb7b618407fdd0
> src/slave/containerizer/mesos/provisioner/docker/store.cpp f357710cb19aec3654b0604f7909d068eaf20095
> src/tests/containerizer/provisioner_docker_tests.cpp 920be77b16178a4458d72145020c015130799ec4
>
>
> Diff: https://reviews.apache.org/r/60511/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 60511: Added MockMetadataManager and test
concurrent prune and pull.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60511/#review187490
-----------------------------------------------------------
PASS: Mesos patch 60511 was successfully built and tested.
Reviews applied: `['55334', '55335', '59687', '56721', '56722', '60471', '62853', '60511']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/60511
- Mesos Reviewbot Windows
On Oct. 9, 2017, 11:21 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60511/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2017, 11:21 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jason Lai.
>
>
> Bugs: MESOS-4945
> https://issues.apache.org/jira/browse/MESOS-4945
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added MockMetadataManager and test concurrent prune and pull.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 954da1681778878c8aff6150002e52ecb648d1bb
> src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp d86afd2a6ff0bf87e624db1c99255c85068bf6ab
> src/slave/containerizer/mesos/provisioner/docker/store.hpp 1cf68665d33bd40a7605d26c96fb7b618407fdd0
> src/slave/containerizer/mesos/provisioner/docker/store.cpp f357710cb19aec3654b0604f7909d068eaf20095
> src/tests/containerizer/provisioner_docker_tests.cpp 920be77b16178a4458d72145020c015130799ec4
>
>
> Diff: https://reviews.apache.org/r/60511/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 60511: Added MockMetadataManager and test
concurrent prune and pull.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60511/#review188694
-----------------------------------------------------------
FAIL: Failed to apply the current review.
Failed command: `python.exe .\support\apply-reviews.py -n -r 60511`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/60511
Relevant logs:
- [apply-review-60511-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/60511/logs/apply-review-60511-stdout.log):
```
error: patch failed: src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp:103
error: src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp: patch does not apply
error: patch failed: src/tests/containerizer/provisioner_docker_tests.cpp:393
error: src/tests/containerizer/provisioner_docker_tests.cpp: patch does not apply
```
- Mesos Reviewbot Windows
On Oct. 19, 2017, 4:29 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60511/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2017, 4:29 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jason Lai.
>
>
> Bugs: MESOS-4945
> https://issues.apache.org/jira/browse/MESOS-4945
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added MockMetadataManager and test concurrent prune and pull.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 954da1681778878c8aff6150002e52ecb648d1bb
> src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp d86afd2a6ff0bf87e624db1c99255c85068bf6ab
> src/slave/containerizer/mesos/provisioner/docker/store.hpp 1cf68665d33bd40a7605d26c96fb7b618407fdd0
> src/slave/containerizer/mesos/provisioner/docker/store.cpp f357710cb19aec3654b0604f7909d068eaf20095
> src/tests/containerizer/provisioner_docker_tests.cpp 920be77b16178a4458d72145020c015130799ec4
>
>
> Diff: https://reviews.apache.org/r/60511/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 60511: Added MockMetadataManager and test
concurrent prune and pull.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60511/
-----------------------------------------------------------
(Updated Oct. 19, 2017, 4:29 p.m.)
Review request for mesos, Gilbert Song and Jason Lai.
Bugs: MESOS-4945
https://issues.apache.org/jira/browse/MESOS-4945
Repository: mesos
Description
-------
Added MockMetadataManager and test concurrent prune and pull.
Diffs
-----
src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 954da1681778878c8aff6150002e52ecb648d1bb
src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp d86afd2a6ff0bf87e624db1c99255c85068bf6ab
src/slave/containerizer/mesos/provisioner/docker/store.hpp 1cf68665d33bd40a7605d26c96fb7b618407fdd0
src/slave/containerizer/mesos/provisioner/docker/store.cpp f357710cb19aec3654b0604f7909d068eaf20095
src/tests/containerizer/provisioner_docker_tests.cpp 920be77b16178a4458d72145020c015130799ec4
Diff: https://reviews.apache.org/r/60511/diff/6/
Testing
-------
Thanks,
Zhitao Li
Re: Review Request 60511: Added MockMetadataManager and test
concurrent prune and pull.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60511/
-----------------------------------------------------------
(Updated Oct. 9, 2017, 11:21 p.m.)
Review request for mesos, Gilbert Song and Jason Lai.
Changes
-------
Update interface and patch dependency.
Bugs: MESOS-4945
https://issues.apache.org/jira/browse/MESOS-4945
Repository: mesos
Description
-------
Added MockMetadataManager and test concurrent prune and pull.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 954da1681778878c8aff6150002e52ecb648d1bb
src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp d86afd2a6ff0bf87e624db1c99255c85068bf6ab
src/slave/containerizer/mesos/provisioner/docker/store.hpp 1cf68665d33bd40a7605d26c96fb7b618407fdd0
src/slave/containerizer/mesos/provisioner/docker/store.cpp f357710cb19aec3654b0604f7909d068eaf20095
src/tests/containerizer/provisioner_docker_tests.cpp 920be77b16178a4458d72145020c015130799ec4
Diff: https://reviews.apache.org/r/60511/diff/6/
Changes: https://reviews.apache.org/r/60511/diff/5-6/
Testing
-------
Thanks,
Zhitao Li