You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by rj...@gmail.com on 2013/07/18 17:14:53 UTC
Review Request 12722: Sqoop2: Rename queries in Derby repository to have the
same naming scheme
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12722/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-1135
https://issues.apache.org/jira/browse/SQOOP-1135
Repository: sqoop-sqoop2
Description
-------
Adding SQ prefix to the variables.
Diffs
-----
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java f717abf
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java b2cd6cc
Diff: https://reviews.apache.org/r/12722/diff/
Testing
-------
Done
Thanks,
vasanthkumar
Re: Review Request 12722: Sqoop2: Rename queries in Derby repository to have
the same naming scheme
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12722/#review23389
-----------------------------------------------------------
Hi Vasanth,
thank you for taking this JIRA! I think that the the prefix _SQ_ is implied, so I would suggest to remove it rather than to add it (in the query constant names).
Jarcec
- Jarek Cecho
On July 18, 2013, 3:14 p.m., vasanthkumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12722/
> -----------------------------------------------------------
>
> (Updated July 18, 2013, 3:14 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1135
> https://issues.apache.org/jira/browse/SQOOP-1135
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Adding SQ prefix to the variables.
>
>
> Diffs
> -----
>
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java f717abf
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java b2cd6cc
>
> Diff: https://reviews.apache.org/r/12722/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> vasanthkumar
>
>