RE: svn commit: r1606770 - /subversion/trunk/subversion/tests/cmdline/svnadmin_tests.py

[Bert Huijben <be...@qqmail.nl>]

> -----Original Message-----
> From: breser@apache.org [mailto:breser@apache.org]
> Sent: maandag 30 juni 2014 17:12
> To: commits@subversion.apache.org
> Subject: svn commit: r1606770 -
> /subversion/trunk/subversion/tests/cmdline/svnadmin_tests.py
> 
> Author: breser
> Date: Mon Jun 30 15:12:26 2014
> New Revision: 1606770
> 
> URL: http://svn.apache.org/r1606770
> Log:
> Fix svnadmin_tests.py with Python versions before 2.6.
> 
> * subversion/tests/cmdline/svnadmin_tests.py
>   (modify_time): Use old style formatting rather than the format() string
>     method added in 2.6.
> 
> Modified:
>     subversion/trunk/subversion/tests/cmdline/svnadmin_tests.py
> 
> Modified: subversion/trunk/subversion/tests/cmdline/svnadmin_tests.py
> URL:
> http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/cmdline/s
> vnadmin_tests.py?rev=1606770&r1=1606769&r2=1606770&view=diff
> ==========================================================
> ====================
> --- subversion/trunk/subversion/tests/cmdline/svnadmin_tests.py (original)
> +++ subversion/trunk/subversion/tests/cmdline/svnadmin_tests.py Mon
> Jun 30 15:12:26 2014
> @@ -328,8 +328,8 @@ class FSFS_Index:
>      """ Modify offset and length of ITEM. """
>      values = self.by_item[item]
> 
> -    values[0] = format(offset, 'x')
> -    values[1] = format(len, 'x')
> +    values[0] = '%x' % offset
> +    values[1] = '%s' % len

Shouldn't that second one be '%x' too?

	Bert 

Re: svn commit: r1606770 - /subversion/trunk/subversion/tests/cmdline/svnadmin_tests.py

[Ben Reser <be...@reser.org>]

On 6/30/14 10:45 AM, Bert Huijben wrote:
> Shouldn't that second one be '%x' too?

Yes typo on my part.  Stefan already fixed it:
http://svn.apache.org/r1606801