You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "G-XD (via GitHub)" <gi...@apache.org> on 2023/10/24 15:20:48 UTC
[PR] feat(core): exposing `Metadata::metakey()` api [incubator-opendal]
G-XD opened a new pull request, #3373:
URL: https://github.com/apache/incubator-opendal/pull/3373
Related: https://github.com/apache/incubator-opendal/pull/3333#discussion_r1369493076
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): exposing `Metadata::metakey()` api [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #3373:
URL: https://github.com/apache/incubator-opendal/pull/3373#discussion_r1370635853
##########
core/src/types/metadata.rs:
##########
@@ -75,7 +75,7 @@ impl Metadata {
}
/// Get the bit from metadata.
- pub(crate) fn bit(&self) -> FlagSet<Metakey> {
+ pub fn metakey(&self) -> FlagSet<Metakey> {
Review Comment:
Please polish the API docs. Maybe we should also rename bit to metakey. Besides, maybe we should also update with_bit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): exposing `Metadata::metakey()` api [incubator-opendal]
Posted by "G-XD (via GitHub)" <gi...@apache.org>.
G-XD commented on code in PR #3373:
URL: https://github.com/apache/incubator-opendal/pull/3373#discussion_r1371113623
##########
core/src/types/metadata.rs:
##########
@@ -75,7 +75,7 @@ impl Metadata {
}
/// Get the bit from metadata.
- pub(crate) fn bit(&self) -> FlagSet<Metakey> {
+ pub fn metakey(&self) -> FlagSet<Metakey> {
Review Comment:
Ok, should we update `contains_bit` together?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): exposing `Metadata::metakey()` api [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #3373:
URL: https://github.com/apache/incubator-opendal/pull/3373#discussion_r1371122694
##########
core/src/types/metadata.rs:
##########
@@ -75,7 +75,7 @@ impl Metadata {
}
/// Get the bit from metadata.
- pub(crate) fn bit(&self) -> FlagSet<Metakey> {
+ pub fn metakey(&self) -> FlagSet<Metakey> {
Review Comment:
Yep, let's do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core): exposing `Metadata::metakey()` api [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #3373:
URL: https://github.com/apache/incubator-opendal/pull/3373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org