You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by ov...@apache.org on 2022/11/21 06:47:50 UTC
[echarts] 01/01: fix(stack): revert pr #17809
This is an automated email from the ASF dual-hosted git repository.
ovilia pushed a commit to branch release-dev
in repository https://gitbox.apache.org/repos/asf/echarts.git
commit 106907deb1ccc8975e14d5016a71bf3dee659642
Author: Ovilia <zw...@gmail.com>
AuthorDate: Mon Nov 21 14:45:07 2022 +0800
fix(stack): revert pr #17809
---
src/processor/dataStack.ts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/processor/dataStack.ts b/src/processor/dataStack.ts
index fb0815426..824e63059 100644
--- a/src/processor/dataStack.ts
+++ b/src/processor/dataStack.ts
@@ -131,8 +131,8 @@ function calculateStack(stackInfoList: StackInfo[]) {
stackStrategy === 'all' // single stack group
|| (stackStrategy === 'positive' && val > 0)
|| (stackStrategy === 'negative' && val < 0)
- || (stackStrategy === 'samesign' && sum > 0 && val > 0) // All positive stack
- || (stackStrategy === 'samesign' && sum < 0 && val < 0) // All negative stack
+ || (stackStrategy === 'samesign' && sum >= 0 && val > 0) // All positive stack
+ || (stackStrategy === 'samesign' && sum <= 0 && val < 0) // All negative stack
) {
// The sum has to be very small to be affected by the
// floating arithmetic problem. An incorrect result will probably
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org