You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Le Minh Nghia (Code Review)" <ge...@cloudera.org> on 2018/07/13 15:58:48 UTC

[Impala-ASF-CR] IMPALA-1624: Allow toggling and unsetting some command-line options inside impala-shell

Hello Zoltan Borok-Nagy, Csaba Ringhofer, Jinchul Kim, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10900

to look at the new patch set (#3).

Change subject: IMPALA-1624: Allow toggling and unsetting some command-line options inside impala-shell
......................................................................

IMPALA-1624: Allow toggling and unsetting some command-line options inside impala-shell

This change provides a way to modify command-line options like -B,
--output_file and --delimiter inside impala-shell without quitting
the shell and then restarting again.
Also fixed IMPALA-7286

Testing:
Added tests for all new options in test_shell_interactive.py

Change-Id: Id8d4487c24f24806223bfd5c54336914e3afd763
---
M shell/impala_shell.py
M tests/shell/test_shell_interactive.py
2 files changed, 72 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/10900/3
-- 
To view, visit http://gerrit.cloudera.org:8080/10900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id8d4487c24f24806223bfd5c54336914e3afd763
Gerrit-Change-Number: 10900
Gerrit-PatchSet: 3
Gerrit-Owner: Le Minh Nghia <le...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Jinchul Kim <ji...@gmail.com>
Gerrit-Reviewer: Le Minh Nghia <le...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>