[GitHub] [ozone] smengcl commented on a diff in pull request #4108: HDDS-7607. [Snapshot] SnapshotDiff command lists unmodified file as modified

[GitBox <gi...@apache.org>]

smengcl commented on code in PR #4108:
URL: https://github.com/apache/ozone/pull/4108#discussion_r1060879723


##########
hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/om/helpers/TestOmKeyInfo.java:
##########
@@ -145,7 +145,7 @@ private void createdAndTest(boolean isMPU) {
 
     // Because for OmKeyLocationInfoGroup we have not implemented equals()
     // method, so it checks only references.
-    Assert.assertNotEquals(key, cloneKey);
+    Assert.assertEquals(key, cloneKey);

Review Comment:
   Oh, got it.
   
   Now that we implemented equals() in OmKeyLocationInfoGroup, should we change the command right above this line as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org