[GitHub] [incubator-mesatee] dingelish opened a new pull request #86: Use environment variable to configure IAS SPID/KEY

[GitBox <gi...@apache.org>]

dingelish opened a new pull request #86: Use environment variable to configure IAS SPID/KEY
URL: https://github.com/apache/incubator-mesatee/pull/86
 
 
   ## Description
   
   Current design of IAS configuration is not friendly to k8s. #80 discussed it. In this PR, I updated mesatee_config to acquire IAS key/spid from environment variables specified in `config.toml`. Updated CI scripts accordingly.
   
   This is a **breaking change**. The previous configuration (ias_key.txt + ias_spid.txt) is deprecated.
   
   Fixes #80 
   
   ## Type of change (select applied and DELETE the others)
   
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
   - [ ] API change with a documentation update
   - [ ] Additional test coverage
   - [ ] Code cleanup or just sync with upstream third-party crates
   
   ## How Has This Been Tested?
   
   CI script updated and passed. [proof](http://ci.mesalock-linux.org/dingelish/incubator-mesatee/18)
   
   ## Checklist (check ALL before submitting PR, even not applicable)
   
   - [x] Fork the repo and create your branch from `master`.
   - [x] If you've added code that should be tested, add tests.
   - [x] If you've changed APIs, update the documentation.
   - [x] Ensure the tests pass (see CI results).
   - [x] Make sure your code lints/format.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mesatee.apache.org
For additional commands, e-mail: dev-help@mesatee.apache.org