You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2014/10/27 17:21:18 UTC
Review Request 27230: Alerts: Convert Script-Style HDFS and Hive
Alerts From Nagios
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27230/
-----------------------------------------------------------
Review request for Ambari, Nate Cole and Tom Beerbower.
Bugs: AMBARI-7986
https://issues.apache.org/jira/browse/AMBARI-7986
Repository: ambari
Description
-------
Finishing HDFS and Hive Nagios alert conversion by including the new SCRIPT alerts.
Diffs
-----
ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 2547dd0
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json c506c32
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/files/alert_checkpoint_time.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/alerts.json c97775d
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_hive_thrift_port.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_webhcat_server.py PRE-CREATION
Diff: https://reviews.apache.org/r/27230/diff/
Testing
-------
Each script was tested against an installed cluster for each possible path:
1) Invalid URLs
2) URLs that return unexpected data
3) URLs that return correct data
Thanks,
Jonathan Hurley
Re: Review Request 27230: Alerts: Convert Script-Style HDFS, Hive,
and YARN Alerts From Nagios
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27230/#review58743
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_webhcat_server.py
<https://reviews.apache.org/r/27230/#comment99879>
For booleans, "if x:" is equivalent to "if x == True:" or even "if x is True:"
- Alejandro Fernandez
On Oct. 27, 2014, 9:11 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27230/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 9:11 p.m.)
>
>
> Review request for Ambari, Nate Cole and Tom Beerbower.
>
>
> Bugs: AMBARI-7986
> https://issues.apache.org/jira/browse/AMBARI-7986
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Finishing HDFS and Hive Nagios alert conversion by including the new SCRIPT alerts.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 2547dd0
> ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py 3268766
> ambari-server/src/main/resources/host_scripts/alert_disk_space.py 3c7a842
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json c506c32
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/files/alert_checkpoint_time.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/alerts.json c97775d
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_hive_thrift_port.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_webhcat_server.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/alerts.json d4af868
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/files/alert_nodemanager_health.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27230/diff/
>
>
> Testing
> -------
>
> Each script was tested against an installed cluster for each possible path:
> 1) Invalid URLs
> 2) URLs that return unexpected data
> 3) URLs that return correct data
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 27230: Alerts: Convert Script-Style HDFS, Hive,
and YARN Alerts From Nagios
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27230/#review58796
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Oct. 27, 2014, 5:11 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27230/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 5:11 p.m.)
>
>
> Review request for Ambari, Nate Cole and Tom Beerbower.
>
>
> Bugs: AMBARI-7986
> https://issues.apache.org/jira/browse/AMBARI-7986
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Finishing HDFS and Hive Nagios alert conversion by including the new SCRIPT alerts.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 2547dd0
> ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py 3268766
> ambari-server/src/main/resources/host_scripts/alert_disk_space.py 3c7a842
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json c506c32
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/files/alert_checkpoint_time.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/alerts.json c97775d
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_hive_thrift_port.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_webhcat_server.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/alerts.json d4af868
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/files/alert_nodemanager_health.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27230/diff/
>
>
> Testing
> -------
>
> Each script was tested against an installed cluster for each possible path:
> 1) Invalid URLs
> 2) URLs that return unexpected data
> 3) URLs that return correct data
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 27230: Alerts: Convert Script-Style HDFS, Hive,
and YARN Alerts From Nagios
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On Oct. 27, 2014, 5:15 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/host_scripts/alert_disk_space.py, line 33
> > <https://reviews.apache.org/r/27230/diff/2/?file=734512#file734512line33>
> >
> > host_name is not actually used in this function.
Because of the nature of how script alerts are run, it's necessary to have the ScriptAlert class pass it in when execute is invoked. It's part of the contract.
> On Oct. 27, 2014, 5:15 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/files/alert_checkpoint_time.py, line 124
> > <https://reviews.apache.org/r/27230/diff/2/?file=734514#file734514line124>
> >
> > In all of these tuples, (a, b) == ((a, b))
Agreed, I'll fix the double-tuple-ing.
> On Oct. 27, 2014, 5:15 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_webhcat_server.py, line 72
> > <https://reviews.apache.org/r/27230/diff/2/?file=734517#file734517line72>
> >
> > Can just use "if security_enabled:"
No, we cannot.
security_enabled = False
if security_enabled:
print 'Foo'
# Foo
The construct if <variable> checks for whether it has been defined, not its value.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27230/#review58684
-----------------------------------------------------------
On Oct. 27, 2014, 5:11 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27230/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 5:11 p.m.)
>
>
> Review request for Ambari, Nate Cole and Tom Beerbower.
>
>
> Bugs: AMBARI-7986
> https://issues.apache.org/jira/browse/AMBARI-7986
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Finishing HDFS and Hive Nagios alert conversion by including the new SCRIPT alerts.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 2547dd0
> ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py 3268766
> ambari-server/src/main/resources/host_scripts/alert_disk_space.py 3c7a842
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json c506c32
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/files/alert_checkpoint_time.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/alerts.json c97775d
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_hive_thrift_port.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_webhcat_server.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/alerts.json d4af868
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/files/alert_nodemanager_health.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27230/diff/
>
>
> Testing
> -------
>
> Each script was tested against an installed cluster for each possible path:
> 1) Invalid URLs
> 2) URLs that return unexpected data
> 3) URLs that return correct data
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 27230: Alerts: Convert Script-Style HDFS, Hive,
and YARN Alerts From Nagios
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27230/#review58684
-----------------------------------------------------------
ambari-server/src/main/resources/host_scripts/alert_disk_space.py
<https://reviews.apache.org/r/27230/#comment99773>
host_name is not actually used in this function.
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/files/alert_checkpoint_time.py
<https://reviews.apache.org/r/27230/#comment99776>
In all of these tuples, (a, b) == ((a, b))
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_webhcat_server.py
<https://reviews.apache.org/r/27230/#comment99777>
Can just use "if security_enabled:"
- Alejandro Fernandez
On Oct. 27, 2014, 9:11 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27230/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 9:11 p.m.)
>
>
> Review request for Ambari, Nate Cole and Tom Beerbower.
>
>
> Bugs: AMBARI-7986
> https://issues.apache.org/jira/browse/AMBARI-7986
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Finishing HDFS and Hive Nagios alert conversion by including the new SCRIPT alerts.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 2547dd0
> ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py 3268766
> ambari-server/src/main/resources/host_scripts/alert_disk_space.py 3c7a842
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json c506c32
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/files/alert_checkpoint_time.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/alerts.json c97775d
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_hive_thrift_port.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_webhcat_server.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/alerts.json d4af868
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/files/alert_nodemanager_health.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27230/diff/
>
>
> Testing
> -------
>
> Each script was tested against an installed cluster for each possible path:
> 1) Invalid URLs
> 2) URLs that return unexpected data
> 3) URLs that return correct data
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 27230: Alerts: Convert Script-Style HDFS, Hive,
and YARN Alerts From Nagios
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27230/
-----------------------------------------------------------
(Updated Oct. 27, 2014, 5:11 p.m.)
Review request for Ambari, Nate Cole and Tom Beerbower.
Summary (updated)
-----------------
Alerts: Convert Script-Style HDFS, Hive, and YARN Alerts From Nagios
Bugs: AMBARI-7986
https://issues.apache.org/jira/browse/AMBARI-7986
Repository: ambari
Description
-------
Finishing HDFS and Hive Nagios alert conversion by including the new SCRIPT alerts.
Diffs
-----
ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 2547dd0
ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py 3268766
ambari-server/src/main/resources/host_scripts/alert_disk_space.py 3c7a842
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json c506c32
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/files/alert_checkpoint_time.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/alerts.json c97775d
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_hive_thrift_port.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_webhcat_server.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/alerts.json d4af868
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/files/alert_nodemanager_health.py PRE-CREATION
Diff: https://reviews.apache.org/r/27230/diff/
Testing
-------
Each script was tested against an installed cluster for each possible path:
1) Invalid URLs
2) URLs that return unexpected data
3) URLs that return correct data
Thanks,
Jonathan Hurley
Re: Review Request 27230: Alerts: Convert Script-Style HDFS and Hive
Alerts From Nagios
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27230/
-----------------------------------------------------------
(Updated Oct. 27, 2014, 5:10 p.m.)
Review request for Ambari, Nate Cole and Tom Beerbower.
Changes
-------
Updated with the changes to allow the host_name to be passed in. In the cases where we need it, and it's not part of the parameters and it's not passed in, then we still will default to fqdn.
Added the last YARN alert to this patch, too.
Bugs: AMBARI-7986
https://issues.apache.org/jira/browse/AMBARI-7986
Repository: ambari
Description
-------
Finishing HDFS and Hive Nagios alert conversion by including the new SCRIPT alerts.
Diffs (updated)
-----
ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 2547dd0
ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py 3268766
ambari-server/src/main/resources/host_scripts/alert_disk_space.py 3c7a842
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json c506c32
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/files/alert_checkpoint_time.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/alerts.json c97775d
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_hive_thrift_port.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_webhcat_server.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/alerts.json d4af868
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/files/alert_nodemanager_health.py PRE-CREATION
Diff: https://reviews.apache.org/r/27230/diff/
Testing
-------
Each script was tested against an installed cluster for each possible path:
1) Invalid URLs
2) URLs that return unexpected data
3) URLs that return correct data
Thanks,
Jonathan Hurley
Re: Review Request 27230: Alerts: Convert Script-Style HDFS and Hive
Alerts From Nagios
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27230/#review58667
-----------------------------------------------------------
Ship it!
Ship It!
- Tom Beerbower
On Oct. 27, 2014, 4:21 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27230/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 4:21 p.m.)
>
>
> Review request for Ambari, Nate Cole and Tom Beerbower.
>
>
> Bugs: AMBARI-7986
> https://issues.apache.org/jira/browse/AMBARI-7986
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Finishing HDFS and Hive Nagios alert conversion by including the new SCRIPT alerts.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 2547dd0
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json c506c32
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/files/alert_checkpoint_time.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/alerts.json c97775d
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_hive_thrift_port.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_webhcat_server.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27230/diff/
>
>
> Testing
> -------
>
> Each script was tested against an installed cluster for each possible path:
> 1) Invalid URLs
> 2) URLs that return unexpected data
> 3) URLs that return correct data
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 27230: Alerts: Convert Script-Style HDFS and Hive
Alerts From Nagios
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On Oct. 27, 2014, 3:15 p.m., Nate Cole wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_hive_thrift_port.py, lines 43-44
> > <https://reviews.apache.org/r/27230/diff/1/?file=734122#file734122line43>
> >
> > Just curious, why a tuple and not a list? tuples are like struct's, heterogenous and lists are typically homogenous
I chose a tuple since they are immutable - I agree that lists are for homogenous collections. I'd like to keep it a tuple for now since I really don't know why I might have to return from this function int he future.
> On Oct. 27, 2014, 3:15 p.m., Nate Cole wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_webhcat_server.py, line 77
> > <https://reviews.apache.org/r/27230/diff/1/?file=734123#file734123line77>
> >
> > May want to check into alternatives here, we've been burned with this when socket.getfqdn() doesn't return what the process is bound to.
Fixed.
I didn't realize that this could be something other than the host name that is accessible from this host. Thanks for pointing out that the host name is part of the base alert and can be passed into the scripts.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27230/#review58657
-----------------------------------------------------------
On Oct. 27, 2014, 12:21 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27230/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 12:21 p.m.)
>
>
> Review request for Ambari, Nate Cole and Tom Beerbower.
>
>
> Bugs: AMBARI-7986
> https://issues.apache.org/jira/browse/AMBARI-7986
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Finishing HDFS and Hive Nagios alert conversion by including the new SCRIPT alerts.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 2547dd0
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json c506c32
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/files/alert_checkpoint_time.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/alerts.json c97775d
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_hive_thrift_port.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_webhcat_server.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27230/diff/
>
>
> Testing
> -------
>
> Each script was tested against an installed cluster for each possible path:
> 1) Invalid URLs
> 2) URLs that return unexpected data
> 3) URLs that return correct data
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 27230: Alerts: Convert Script-Style HDFS and Hive
Alerts From Nagios
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27230/#review58657
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_hive_thrift_port.py
<https://reviews.apache.org/r/27230/#comment99732>
Just curious, why a tuple and not a list? tuples are like struct's, heterogenous and lists are typically homogenous
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_webhcat_server.py
<https://reviews.apache.org/r/27230/#comment99733>
May want to check into alternatives here, we've been burned with this when socket.getfqdn() doesn't return what the process is bound to.
- Nate Cole
On Oct. 27, 2014, 12:21 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27230/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 12:21 p.m.)
>
>
> Review request for Ambari, Nate Cole and Tom Beerbower.
>
>
> Bugs: AMBARI-7986
> https://issues.apache.org/jira/browse/AMBARI-7986
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Finishing HDFS and Hive Nagios alert conversion by including the new SCRIPT alerts.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 2547dd0
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json c506c32
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/files/alert_checkpoint_time.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/alerts.json c97775d
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_hive_thrift_port.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/alert_webhcat_server.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27230/diff/
>
>
> Testing
> -------
>
> Each script was tested against an installed cluster for each possible path:
> 1) Invalid URLs
> 2) URLs that return unexpected data
> 3) URLs that return correct data
>
>
> Thanks,
>
> Jonathan Hurley
>
>