[jira] [Commented] (AVRO-1260) Ruby: Performance improvements for parsing

["Doug Cutting (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AVRO-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13583368#comment-13583368 ] 

Doug Cutting commented on AVRO-1260:
------------------------------------

Martin, this change looks like it might not be back-compatible.  Existing Ruby applications that use, e.g., Schema::PRIMITIVE_TYPES won't work as before.  So probably we should include this in 1.8.0 rather than 1.7.4?  (Avro permits incompatible API changes in point releases.  Major releases imply an incompatible change to data formats.)
                
> Ruby: Performance improvements for parsing
> ------------------------------------------
>
>                 Key: AVRO-1260
>                 URL: https://issues.apache.org/jira/browse/AVRO-1260
>             Project: Avro
>          Issue Type: Improvement
>          Components: ruby
>    Affects Versions: 1.7.3
>            Reporter: Martin Kleppmann
>         Attachments: AVRO-1260.patch
>
>
> I've made a few performance improvements to the Ruby Avro decoder. In my tests (decoding a complex record with many fields and nested records), I saw a 40% speedup on MRI 1.8.7 and a 20% speedup on MRI 1.9.3. The improved code also makes about half as many object allocations as before.
> Main changes are:
> * Using symbols instead of strings for the various schema types (there was actually a FIXME in the code for this, now fixed)
> * Added a few memoizations to avoid unnecessarily recomputing values
> I've tried to keep the API unchanged — {{Avro::Schema#type}} still returns a string, as users may be relying on the type ({{Avro::Schema#type_sym}} has the symbolized version). So I don't think this patch introduces any compatibility problems (as long as apps aren't relying on internals of the Avro library).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira