You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "aleksraiden (via GitHub)" <gi...@apache.org> on 2024/05/24 07:49:44 UTC
[PR] Use hset instead of hmset at test kvrocks2redis [kvrocks]
aleksraiden opened a new pull request, #2328:
URL: https://github.com/apache/kvrocks/pull/2328
HMSET are deprecated, so small fix to avoid an warning in test (/home/runner/work/kvrocks/kvrocks/utils/kvrocks2redis/tests/check_consistency.py:103: DeprecationWarning: Redis.hmset() is deprecated. Use Redis.hset() instead)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use hset instead of hmset at test kvrocks2redis [kvrocks]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2328:
URL: https://github.com/apache/kvrocks/pull/2328#issuecomment-2132534277
## [](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=2328) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_kvrocks&pullRequest=2328&resolved=false&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_kvrocks&pullRequest=2328&resolutions=WONTFIX)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kvrocks&pullRequest=2328&resolved=false&sinceLeakPeriod=true)
 No data about Coverage
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_kvrocks&pullRequest=2328&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=2328)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use hset instead of hmset at test kvrocks2redis [kvrocks]
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk merged PR #2328:
URL: https://github.com/apache/kvrocks/pull/2328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use hset instead of hmset at test kvrocks2redis [kvrocks]
Posted by "aleksraiden (via GitHub)" <gi...@apache.org>.
aleksraiden commented on code in PR #2328:
URL: https://github.com/apache/kvrocks/pull/2328#discussion_r1614794778
##########
utils/kvrocks2redis/tests/check_consistency.py:
##########
@@ -100,7 +100,7 @@ def _import_and_compare(self, num):
self.src_cli.incr(incr_key)
hash_key = f'hash_key_{i}'
hash_value = {'field1': f'field1_value_{i}', 'field2': f'field2_value_{i}'}
- self.src_cli.hmset(hash_key, hash_value)
+ self.src_cli.hset(hash_key, hash_value)
Review Comment:
Hmmm, yes, You are right, my mistake, need to rewrite code. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use hset instead of hmset at test kvrocks2redis [kvrocks]
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on code in PR #2328:
URL: https://github.com/apache/kvrocks/pull/2328#discussion_r1614465236
##########
utils/kvrocks2redis/tests/check_consistency.py:
##########
@@ -100,7 +100,7 @@ def _import_and_compare(self, num):
self.src_cli.incr(incr_key)
hash_key = f'hash_key_{i}'
hash_value = {'field1': f'field1_value_{i}', 'field2': f'field2_value_{i}'}
- self.src_cli.hmset(hash_key, hash_value)
+ self.src_cli.hset(hash_key, hash_value)
Review Comment:
@aleksraiden Seems redis-py didn't support the object as its value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use hset instead of hmset at test kvrocks2redis [kvrocks]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2328:
URL: https://github.com/apache/kvrocks/pull/2328#issuecomment-2132040942
## [](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=2328) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_kvrocks&pullRequest=2328&resolved=false&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_kvrocks&pullRequest=2328&resolutions=WONTFIX)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kvrocks&pullRequest=2328&resolved=false&sinceLeakPeriod=true)
 No data about Coverage
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_kvrocks&pullRequest=2328&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=2328)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org