You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/02/09 16:37:15 UTC

[GitHub] [flink] mas-chen commented on a change in pull request #18668: [FLINK-25697][Runtime / Metrics] introduce port url config for prometheus push gateway a…

mas-chen commented on a change in pull request #18668:
URL: https://github.com/apache/flink/pull/18668#discussion_r802866587



##########
File path: flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
##########
@@ -57,6 +60,17 @@
         this.deleteOnShutdown = deleteOnShutdown;
     }
 
+    PrometheusPushGatewayReporter(
+            String hostUrl,
+            String jobName,

Review comment:
       Ah, I misinterpreted the public evolving annotation. Thought I shouldn't introduce breaking changes to this class, will clean it up.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org