You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/19 13:56:37 UTC

[GitHub] [arrow-datafusion] xudong963 commented on a change in pull request #1607: consolidate binary_expr coercion rule code into `binary_rule.rs` module

xudong963 commented on a change in pull request #1607:
URL: https://github.com/apache/arrow-datafusion/pull/1607#discussion_r787760471



##########
File path: datafusion/src/physical_plan/coercion_rule/binary_rule.rs
##########
@@ -15,15 +15,11 @@
 // specific language governing permissions and limitations
 // under the License.
 
-//! Support the coercion rule for binary operation
+//! Coercion rules for  matching argument types for binary operators

Review comment:
       ocd, lol
   ```suggestion
   //! Coercion rules for matching argument types for binary operators
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org