You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "pivotal-eshu (GitHub)" <gi...@apache.org> on 2018/10/11 19:10:29 UTC
[GitHub] [geode] pivotal-eshu opened pull request #2594: GEODE-5849:
Do not wrap CacheClosedException if client cache is closing.
[ Full content available at: https://github.com/apache/geode/pull/2594 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] pivotal-eshu closed pull request #2594: GEODE-5849:
Do not wrap CacheClosedException if client cache is closing.
Posted by "pivotal-eshu (GitHub)" <gi...@apache.org>.
[ pull request closed by pivotal-eshu ]
[ Full content available at: https://github.com/apache/geode/pull/2594 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] pivotal-eshu commented on pull request #2594:
GEODE-5849: Do not wrap CacheClosedException if client cache is closing.
Posted by "pivotal-eshu (GitHub)" <gi...@apache.org>.
Actually, the method may not throw CacheClosedException but return CacheClosedException instead. Made the change necessary.
[ Full content available at: https://github.com/apache/geode/pull/2594 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] pivotal-eshu commented on pull request #2594:
GEODE-5849: Do not wrap CacheClosedException if client cache is closing.
Posted by "pivotal-eshu (GitHub)" <gi...@apache.org>.
You are right, it should not set runtimeException as getCancelCriterion().generateCancelledException would throw exception if cache is closing. I was just use the code in basicPutAll.
[ Full content available at: https://github.com/apache/geode/pull/2594 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] dschneider-pivotal commented on pull request #2594:
GEODE-5849: Do not wrap CacheClosedException if client cache is closing.
Posted by "dschneider-pivotal (GitHub)" <gi...@apache.org>.
why do you have two assignments of "runtimeException"? Seems like the second assignment just throws away your new one.
[ Full content available at: https://github.com/apache/geode/pull/2594 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org