You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "hudi-bot (via GitHub)" <gi...@apache.org> on 2025/11/30 03:26:07 UTC
[I] Fix TestHoodieClientOnCopyOnWriteStorage Tests with modular private methods [hudi]
hudi-bot opened a new issue, #14508:
URL: https://github.com/apache/hudi/issues/14508
## JIRA info
- Link: https://issues.apache.org/jira/browse/HUDI-347
- Type: Test
- Epic: https://issues.apache.org/jira/browse/HUDI-3303
---
## Comments
24/Feb/22 14:32;Kalluri;[~shivnarayan] can you elaborate on "{*}Fix TestHoodieClientOnCopyOnWriteStorage Tests with modular private methods{*}"
Are we doing this refactoring to make the tests more readable to make their intent clear ?;;;
---
24/Feb/22 21:20;shivnarayan;yes. some of the initial tests written are very modularized. but later ones were not written in a reusable manner. And there is scope for making itm more modular. and it will help in adding more tests in future.
;;;
---
24/Feb/22 23:40;Kalluri;[~shivnarayan] the below 2 tests seem like a good place to start with well over a 100 lines of code each, do you agree.
private void testUpsertsInternal(HoodieWriteConfig config,
Function3<JavaRDD<WriteStatus>, SparkRDDWriteClient, JavaRDD<HoodieRecord>, String> writeFn, boolean isPrepped)
and
private void testUpsertsUpdatePartitionPath(IndexType indexType, HoodieWriteConfig config
and
testSmallInsertHandlingForUpserts;;;
---
26/Feb/22 02:08;shivnarayan;yes, makes sense. please go ahead. ;;;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Fix TestHoodieClientOnCopyOnWriteStorage Tests with modular private methods [hudi]
Posted by "sushrut-raina (via GitHub)" <gi...@apache.org>.
sushrut-raina commented on issue #14508:
URL: https://github.com/apache/hudi/issues/14508#issuecomment-3959831860
I can take this up.. fyi @rahil-c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Fix TestHoodieClientOnCopyOnWriteStorage Tests with modular private methods [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous closed issue #14508: Fix TestHoodieClientOnCopyOnWriteStorage Tests with modular private methods
URL: https://github.com/apache/hudi/issues/14508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Fix TestHoodieClientOnCopyOnWriteStorage Tests with modular private methods [hudi]
Posted by "sushrut-raina (via GitHub)" <gi...@apache.org>.
sushrut-raina commented on issue #14508:
URL: https://github.com/apache/hudi/issues/14508#issuecomment-4155234061
since this is merged i will close my PR ... fyi @yaojiejia @rahil-c @voonhous
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Fix TestHoodieClientOnCopyOnWriteStorage Tests with modular private methods [hudi]
Posted by "yaojiejia (via GitHub)" <gi...@apache.org>.
yaojiejia commented on issue #14508:
URL: https://github.com/apache/hudi/issues/14508#issuecomment-4120568520
Hi @rahil-c I noticed this issue is currently assigned to sushrut but since there hasn’t been recent activity, I went ahead and opened a PR to help move things forward. If sushrut raises another PR you can prioritize on sushrut's PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org