You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "tibrewalpratik17 (via GitHub)" <gi...@apache.org> on 2023/02/24 09:38:28 UTC
[GitHub] [pinot] tibrewalpratik17 opened a new pull request, #10336: [Multistage] Allow queries on multiple tables of same tenant to be executed from controller UI
tibrewalpratik17 opened a new pull request, #10336:
URL: https://github.com/apache/pinot/pull/10336
At present, via Controller UI we can only execute multistage queries on DefaultTenant. This patch checks if the tables queried are having atleast one common tenant and allows queries to be executed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on a diff in pull request #10336: [Multistage] Allow queries on multiple tables of same tenant to be executed from controller UI
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on code in PR #10336:
URL: https://github.com/apache/pinot/pull/10336#discussion_r1119332970
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##########
@@ -170,10 +171,10 @@ private String getMultiStageQueryResponse(String query, String queryOptions, Htt
return QueryException.ACCESS_DENIED_ERROR.toString();
}
- // Get brokers, only DEFAULT tenant is supported for now.
- // TODO: implement logic that only allows executing query where all accessed tables are within the same tenant.
- List<String> instanceIds = new ArrayList<>(_pinotHelixResourceManager.getAllInstancesForBrokerTenant(
- TagNameUtils.DEFAULT_TENANT_NAME));
+ SqlNodeAndOptions sqlNodeAndOptions = RequestUtils.parseQuery(query);
+ List<String> tableNames = CalciteSqlParser.extractTableNamesFromNode(sqlNodeAndOptions.getSqlNode());
+
+ List<String> instanceIds = getCommonInstances(tableNames);
Review Comment:
this change will probably be useless as
1. the actual broker API only supports default tenant (hard-coded in many places)
2. can only get routing table for its responsible set of tables, but it is responsible for generating stage plan for the entire query.
Thus my suggestion is should we let's limit the scope to "all tables belong to the same tenant, not necessarily 'default'" first?
and try to get it right before we support random tenant combination?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on a diff in pull request #10336: [Multistage] Allow queries on multiple tables of same tenant to be executed from controller UI
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on code in PR #10336:
URL: https://github.com/apache/pinot/pull/10336#discussion_r1119423880
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##########
@@ -170,10 +171,10 @@ private String getMultiStageQueryResponse(String query, String queryOptions, Htt
return QueryException.ACCESS_DENIED_ERROR.toString();
}
- // Get brokers, only DEFAULT tenant is supported for now.
- // TODO: implement logic that only allows executing query where all accessed tables are within the same tenant.
- List<String> instanceIds = new ArrayList<>(_pinotHelixResourceManager.getAllInstancesForBrokerTenant(
- TagNameUtils.DEFAULT_TENANT_NAME));
+ SqlNodeAndOptions sqlNodeAndOptions = RequestUtils.parseQuery(query);
+ List<String> tableNames = CalciteSqlParser.extractTableNamesFromNode(sqlNodeAndOptions.getSqlNode());
+
+ List<String> instanceIds = getCommonInstances(tableNames);
Review Comment:
yeah that's probably b/c the broker you hit is responsible for only a set of tenants and that set of tenants are responsible for all the tables in the query. nevertheless it is not meant to be fully bug-free just b/c it can run.
I can think of several scenarios that this could go wrong in other cluster settings. Let's aim at a single tenant and add tests for different type of configuration of
1. broker tenant
2. server tenant (same, subset, superset of broker)
3. table (identical to broker, identical to server but subset of broker, identical to broker, subset of server) and mix and match multiple tables with the above configuration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] ankitsultana commented on a diff in pull request #10336: [Multistage] Allow queries on multiple tables of same tenant to be executed from controller UI
Posted by "ankitsultana (via GitHub)" <gi...@apache.org>.
ankitsultana commented on code in PR #10336:
URL: https://github.com/apache/pinot/pull/10336#discussion_r1118154098
##########
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java:
##########
@@ -135,6 +135,24 @@ public static SqlNodeAndOptions compileToSqlNodeAndOptions(String sql)
}
}
+ public static List<String> extractTableNamesFromNode(SqlNode sqlNode) {
+ List<String> tableNames = new ArrayList<>();
+ if (sqlNode instanceof SqlSelect) {
+ SqlNode fromNode = ((SqlSelect) sqlNode).getFrom();
+ tableNames.addAll(((SqlIdentifier) fromNode).names);
+ tableNames.addAll(extractTableNamesFromNode(((SqlSelect) sqlNode).getWhere()));
+ } else if (sqlNode instanceof SqlBasicCall) {
+ for (SqlNode node: ((SqlBasicCall) sqlNode).getOperandList()) {
+ tableNames.addAll(extractTableNamesFromNode(node));
+ }
+ } else if (sqlNode instanceof SqlOrderBy) {
Review Comment:
When can the else clause be hit?
##########
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java:
##########
@@ -135,6 +135,24 @@ public static SqlNodeAndOptions compileToSqlNodeAndOptions(String sql)
}
}
+ public static List<String> extractTableNamesFromNode(SqlNode sqlNode) {
Review Comment:
I think we need to add UTs for this.
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##########
@@ -170,10 +171,11 @@ private String getMultiStageQueryResponse(String query, String queryOptions, Htt
return QueryException.ACCESS_DENIED_ERROR.toString();
}
- // Get brokers, only DEFAULT tenant is supported for now.
- // TODO: implement logic that only allows executing query where all accessed tables are within the same tenant.
- List<String> instanceIds = new ArrayList<>(_pinotHelixResourceManager.getAllInstancesForBrokerTenant(
- TagNameUtils.DEFAULT_TENANT_NAME));
+ ObjectNode requestJson = getRequestJson(query, "false", queryOptions);
+ SqlNodeAndOptions sqlNodeAndOptions = RequestUtils.parseQuery(query, requestJson);
Review Comment:
I think we can add an overloaded method: `RequestsUtils.parseQuery(query)` that doesn't take in the requestJson and simply returns a `SqlNodeAndOptions`. The existing method can also use the same.
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##########
@@ -226,6 +228,31 @@ private String getQueryResponse(String query, @Nullable SqlNode sqlNode, String
return sendRequestToBroker(query, instanceId, traceEnabled, queryOptions, httpHeaders);
}
+ // get list of common broker instances for a given set of tables
+ private List<String> getCommonInstances(List<String> tableNames) {
+ boolean firstTable = true;
+ Set<String> brokerInstanceList = new HashSet<>();
Review Comment:
nit: remove `List` from name since this is a set
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##########
@@ -226,6 +228,31 @@ private String getQueryResponse(String query, @Nullable SqlNode sqlNode, String
return sendRequestToBroker(query, instanceId, traceEnabled, queryOptions, httpHeaders);
}
+ // get list of common broker instances for a given set of tables
+ private List<String> getCommonInstances(List<String> tableNames) {
+ boolean firstTable = true;
+ Set<String> brokerInstanceList = new HashSet<>();
+ for (String tableName : tableNames) {
+ String rawTableName = TableNameBuilder.extractRawTableName(_pinotHelixResourceManager
+ .getActualTableName(tableName));
+ List<String> tableBrokerInstances;
+ try {
+ tableBrokerInstances = _pinotHelixResourceManager.getLiveBrokersForTable(rawTableName);
Review Comment:
I think we shouldn't convert this to a raw table name and instead pass the tableName directly. If you use a rawTableName, the `getLiveBrokersForTable` method will return an intersection of the realtime and offline brokers for hybrid tables. If a user decides to use a type-suffix for a hybrid table, we can simply honor that and return live brokers for that type.
I am not sure what the current behavior is for those tables though (would be best to be consistent with that).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on a diff in pull request #10336: [Multistage] Allow queries on multiple tables of same tenant to be executed from controller UI
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on code in PR #10336:
URL: https://github.com/apache/pinot/pull/10336#discussion_r1131945053
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestUtils.java:
##########
@@ -48,6 +48,14 @@ public class RequestUtils {
private RequestUtils() {
}
+ public static SqlNodeAndOptions parseQuery(String query)
+ throws SqlCompilationException {
+ long parserStartTimeNs = System.nanoTime();
+ SqlNodeAndOptions sqlNodeAndOptions = CalciteSqlParser.compileToSqlNodeAndOptions(query);
+ sqlNodeAndOptions.setParseTimeNs(System.nanoTime() - parserStartTimeNs);
+ return sqlNodeAndOptions;
+ }
Review Comment:
use a `private static final JsonNode EMPTY_OBJECT_NODE = new ObjectMapper().createObjectNode();
```suggestion
return parserQuery(query, EMPTY_OBJECT_NODE);
}
```
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestUtils.java:
##########
@@ -48,6 +48,14 @@ public class RequestUtils {
private RequestUtils() {
}
+ public static SqlNodeAndOptions parseQuery(String query)
+ throws SqlCompilationException {
+ long parserStartTimeNs = System.nanoTime();
+ SqlNodeAndOptions sqlNodeAndOptions = CalciteSqlParser.compileToSqlNodeAndOptions(query);
+ sqlNodeAndOptions.setParseTimeNs(System.nanoTime() - parserStartTimeNs);
+ return sqlNodeAndOptions;
+ }
Review Comment:
use a `private static final JsonNode EMPTY_OBJECT_NODE = new ObjectMapper().createObjectNode();`
```suggestion
return parserQuery(query, EMPTY_OBJECT_NODE);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] ankitsultana commented on a diff in pull request #10336: [Multistage] Allow queries on multiple tables of same tenant to be executed from controller UI
Posted by "ankitsultana (via GitHub)" <gi...@apache.org>.
ankitsultana commented on code in PR #10336:
URL: https://github.com/apache/pinot/pull/10336#discussion_r1119302523
##########
pinot-common/src/test/java/org/apache/pinot/sql/parsers/CalciteSqlCompilerTest.java:
##########
@@ -3010,6 +3011,15 @@ public void shouldParseOutsideExprAtTimeZoneExtension() {
Assert.assertEquals(fun.operands.get(0).getFunctionCall().operands.get(1).getLiteral().getStringValue(), "pst");
}
+ @Test
+ public void testExtractTableNamesFromNode() {
Review Comment:
Can you add some more queries here (particularly join queries)? Examples:
```
SELECT COUNT(*) FROM tbl1 WHERE userUUID IN (SELECT userUUID FROM tbl2);
// add a few more cases of this with a mix of IN/Not-In, etc.
```
Some explicit join queries:
```
SELECT A.col1, B.col2 FROM tbl1 AS A JOIN tbl2 AS B ON A.key = B.key WHERE...
```
Some queries which use sub-queries (would be interesting to see if the tmp table name is also returned here):
```
with tmp as (
select col1, count(*) from tbl1 where .. group by col1
)
select sum(col1) from tmp.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] ankitsultana commented on a diff in pull request #10336: [Multistage] Allow queries on multiple tables of same tenant to be executed from controller UI
Posted by "ankitsultana (via GitHub)" <gi...@apache.org>.
ankitsultana commented on code in PR #10336:
URL: https://github.com/apache/pinot/pull/10336#discussion_r1119349115
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##########
@@ -170,10 +171,10 @@ private String getMultiStageQueryResponse(String query, String queryOptions, Htt
return QueryException.ACCESS_DENIED_ERROR.toString();
}
- // Get brokers, only DEFAULT tenant is supported for now.
- // TODO: implement logic that only allows executing query where all accessed tables are within the same tenant.
- List<String> instanceIds = new ArrayList<>(_pinotHelixResourceManager.getAllInstancesForBrokerTenant(
- TagNameUtils.DEFAULT_TENANT_NAME));
+ SqlNodeAndOptions sqlNodeAndOptions = RequestUtils.parseQuery(query);
+ List<String> tableNames = CalciteSqlParser.extractTableNamesFromNode(sqlNodeAndOptions.getSqlNode());
+
+ List<String> instanceIds = getCommonInstances(tableNames);
Review Comment:
> the actual broker API only supports default tenant (hard-coded in many places)
You mean for multistage? We are actually running it in a non-default tenant internally. Queries work if you directly hit the broker that you know is in the tenant that you want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on a diff in pull request #10336: [Multistage] Allow queries on multiple tables of same tenant to be executed from controller UI
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on code in PR #10336:
URL: https://github.com/apache/pinot/pull/10336#discussion_r1119332970
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##########
@@ -170,10 +171,10 @@ private String getMultiStageQueryResponse(String query, String queryOptions, Htt
return QueryException.ACCESS_DENIED_ERROR.toString();
}
- // Get brokers, only DEFAULT tenant is supported for now.
- // TODO: implement logic that only allows executing query where all accessed tables are within the same tenant.
- List<String> instanceIds = new ArrayList<>(_pinotHelixResourceManager.getAllInstancesForBrokerTenant(
- TagNameUtils.DEFAULT_TENANT_NAME));
+ SqlNodeAndOptions sqlNodeAndOptions = RequestUtils.parseQuery(query);
+ List<String> tableNames = CalciteSqlParser.extractTableNamesFromNode(sqlNodeAndOptions.getSqlNode());
+
+ List<String> instanceIds = getCommonInstances(tableNames);
Review Comment:
this change will probably be useless as
1. the actual broker API only supports default tenant (hard-coded in many places)
2. can only get routing table for its responsible set of tables, but it is responsible for generating stage plans for the entire query.
Thus my suggestion is should we let's limit the scope to "all tables belong to the same tenant, not necessarily 'default'" first?
and try to get it E2E right before we support random tenant combinations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on a diff in pull request #10336: [Multistage] Allow queries on multiple tables of same tenant to be executed from controller UI
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on code in PR #10336:
URL: https://github.com/apache/pinot/pull/10336#discussion_r1131946143
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##########
@@ -170,10 +171,19 @@ private String getMultiStageQueryResponse(String query, String queryOptions, Htt
return QueryException.ACCESS_DENIED_ERROR.toString();
}
- // Get brokers, only DEFAULT tenant is supported for now.
- // TODO: implement logic that only allows executing query where all accessed tables are within the same tenant.
- List<String> instanceIds = new ArrayList<>(_pinotHelixResourceManager.getAllInstancesForBrokerTenant(
- TagNameUtils.DEFAULT_TENANT_NAME));
+ SqlNodeAndOptions sqlNodeAndOptions = RequestUtils.parseQuery(query);
+ List<String> tableNames = CalciteSqlParser.extractTableNamesFromNode(sqlNodeAndOptions.getSqlNode());
+ if (tableNames.size() == 0) {
+ return QueryException.SQL_PARSING_ERROR.toString();
+ }
+
+ String brokerTenant = getCommonBrokerTenant(tableNames);
+ String serverTenant = getCommonServerTenant(tableNames);
+ if (brokerTenant == null || serverTenant == null) {
+ return QueryException.TABLES_NOT_ON_SAME_TENANT_ERROR.toString();
Review Comment:
```suggestion
if (brokerTenant == null || serverTenant == null) {
return QueryException.getException(QueryException. BROKER_REQUEST_SEND_ERROR_CODE, new Exception("Unable to dispatch multistage query with multiple tables on different tenant")).toString();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on a diff in pull request #10336: [Multistage] Allow queries on multiple tables of same tenant to be executed from controller UI
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on code in PR #10336:
URL: https://github.com/apache/pinot/pull/10336#discussion_r1119332970
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##########
@@ -170,10 +171,10 @@ private String getMultiStageQueryResponse(String query, String queryOptions, Htt
return QueryException.ACCESS_DENIED_ERROR.toString();
}
- // Get brokers, only DEFAULT tenant is supported for now.
- // TODO: implement logic that only allows executing query where all accessed tables are within the same tenant.
- List<String> instanceIds = new ArrayList<>(_pinotHelixResourceManager.getAllInstancesForBrokerTenant(
- TagNameUtils.DEFAULT_TENANT_NAME));
+ SqlNodeAndOptions sqlNodeAndOptions = RequestUtils.parseQuery(query);
+ List<String> tableNames = CalciteSqlParser.extractTableNamesFromNode(sqlNodeAndOptions.getSqlNode());
+
+ List<String> instanceIds = getCommonInstances(tableNames);
Review Comment:
this change will probably be useless as
1. the actual broker API only supports default tenant (hard-coded in many places)
2. can only get routing table for its responsible set of tables, but it is responsible for generating stage plan for the entire query.
Thus my suggestion is should we let's limit the scope to "all tables belong to the same tenant, not necessarily 'default'" first?
and try to get it E2E right before we support random tenant combinations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] tibrewalpratik17 commented on a diff in pull request #10336: [Multistage] Allow queries on multiple tables of same tenant to be executed from controller UI
Posted by "tibrewalpratik17 (via GitHub)" <gi...@apache.org>.
tibrewalpratik17 commented on code in PR #10336:
URL: https://github.com/apache/pinot/pull/10336#discussion_r1118723829
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##########
@@ -226,6 +228,31 @@ private String getQueryResponse(String query, @Nullable SqlNode sqlNode, String
return sendRequestToBroker(query, instanceId, traceEnabled, queryOptions, httpHeaders);
}
+ // get list of common broker instances for a given set of tables
+ private List<String> getCommonInstances(List<String> tableNames) {
+ boolean firstTable = true;
+ Set<String> brokerInstanceList = new HashSet<>();
+ for (String tableName : tableNames) {
+ String rawTableName = TableNameBuilder.extractRawTableName(_pinotHelixResourceManager
+ .getActualTableName(tableName));
+ List<String> tableBrokerInstances;
+ try {
+ tableBrokerInstances = _pinotHelixResourceManager.getLiveBrokersForTable(rawTableName);
Review Comment:
Yeah good point! I was thinking along the same lines of removing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] tibrewalpratik17 commented on a diff in pull request #10336: [Multistage] Allow queries on multiple tables of same tenant to be executed from controller UI
Posted by "tibrewalpratik17 (via GitHub)" <gi...@apache.org>.
tibrewalpratik17 commented on code in PR #10336:
URL: https://github.com/apache/pinot/pull/10336#discussion_r1119352663
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##########
@@ -170,10 +171,10 @@ private String getMultiStageQueryResponse(String query, String queryOptions, Htt
return QueryException.ACCESS_DENIED_ERROR.toString();
}
- // Get brokers, only DEFAULT tenant is supported for now.
- // TODO: implement logic that only allows executing query where all accessed tables are within the same tenant.
- List<String> instanceIds = new ArrayList<>(_pinotHelixResourceManager.getAllInstancesForBrokerTenant(
- TagNameUtils.DEFAULT_TENANT_NAME));
+ SqlNodeAndOptions sqlNodeAndOptions = RequestUtils.parseQuery(query);
+ List<String> tableNames = CalciteSqlParser.extractTableNamesFromNode(sqlNodeAndOptions.getSqlNode());
+
+ List<String> instanceIds = getCommonInstances(tableNames);
Review Comment:
> Thus my suggestion is should we let's limit the scope to "all tables belong to the same tenant, not necessarily 'default'" first?
This PR takes care of this scenario specifically. At present, queries work fine when we hit brokers directly of a non-default tenant as @ankitsultana mentioned. We want to allow those queries to be pushed down to broker from controller as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on a diff in pull request #10336: [Multistage] Allow queries on multiple tables of same tenant to be executed from controller UI
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on code in PR #10336:
URL: https://github.com/apache/pinot/pull/10336#discussion_r1132824868
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##########
@@ -170,10 +171,20 @@ private String getMultiStageQueryResponse(String query, String queryOptions, Htt
return QueryException.ACCESS_DENIED_ERROR.toString();
}
- // Get brokers, only DEFAULT tenant is supported for now.
- // TODO: implement logic that only allows executing query where all accessed tables are within the same tenant.
- List<String> instanceIds = new ArrayList<>(_pinotHelixResourceManager.getAllInstancesForBrokerTenant(
- TagNameUtils.DEFAULT_TENANT_NAME));
+ SqlNodeAndOptions sqlNodeAndOptions = RequestUtils.parseQuery(query);
+ List<String> tableNames = CalciteSqlParser.extractTableNamesFromNode(sqlNodeAndOptions.getSqlNode());
+ if (tableNames.size() == 0) {
+ return QueryException.SQL_PARSING_ERROR.toString();
+ }
+
+ String brokerTenant = getCommonBrokerTenant(tableNames);
+ String serverTenant = getCommonServerTenant(tableNames);
+ if (brokerTenant == null || serverTenant == null) {
+ return QueryException.getException(QueryException.BROKER_REQUEST_SEND_ERROR,
+ new Exception("Unable to dispatch multistage query with multiple tables on different tenant")).toString();
Review Comment:
can you attach the `tableNames` in the error message to make it more informative?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10336: [Multistage] Allow queries on multiple tables of same tenant to be executed from controller UI
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10336:
URL: https://github.com/apache/pinot/pull/10336#issuecomment-1443428591
# [Codecov](https://codecov.io/gh/apache/pinot/pull/10336?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10336](https://codecov.io/gh/apache/pinot/pull/10336?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7762f4e) into [master](https://codecov.io/gh/apache/pinot/commit/d3c8ec2ec0dc7da2c5dd441eec523a567203b4c4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d3c8ec2) will **decrease** coverage by `38.18%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #10336 +/- ##
=============================================
- Coverage 70.27% 32.09% -38.18%
+ Complexity 5902 236 -5666
=============================================
Files 2027 2027
Lines 109953 109987 +34
Branches 16711 16718 +7
=============================================
- Hits 77273 35305 -41968
- Misses 27259 71532 +44273
+ Partials 5421 3150 -2271
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `24.47% <0.00%> (+0.03%)` | :arrow_up: |
| integration2 | `?` | |
| unittests1 | `?` | |
| unittests2 | `13.75% <0.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/10336?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...org/apache/pinot/sql/parsers/CalciteSqlParser.java](https://codecov.io/gh/apache/pinot/pull/10336?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcWwvcGFyc2Vycy9DYWxjaXRlU3FsUGFyc2VyLmphdmE=) | `71.42% <0.00%> (-12.86%)` | :arrow_down: |
| [...t/controller/api/resources/PinotQueryResource.java](https://codecov.io/gh/apache/pinot/pull/10336?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1Bpbm90UXVlcnlSZXNvdXJjZS5qYXZh) | `9.81% <0.00%> (-44.04%)` | :arrow_down: |
| [...in/java/org/apache/pinot/spi/utils/BytesUtils.java](https://codecov.io/gh/apache/pinot/pull/10336?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvQnl0ZXNVdGlscy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...java/org/apache/pinot/spi/trace/BaseRecording.java](https://codecov.io/gh/apache/pinot/pull/10336?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdHJhY2UvQmFzZVJlY29yZGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...java/org/apache/pinot/spi/trace/NoOpRecording.java](https://codecov.io/gh/apache/pinot/pull/10336?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdHJhY2UvTm9PcFJlY29yZGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ava/org/apache/pinot/spi/config/table/FSTType.java](https://codecov.io/gh/apache/pinot/pull/10336?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvY29uZmlnL3RhYmxlL0ZTVFR5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ava/org/apache/pinot/spi/config/user/RoleType.java](https://codecov.io/gh/apache/pinot/pull/10336?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvY29uZmlnL3VzZXIvUm9sZVR5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ava/org/apache/pinot/spi/data/MetricFieldSpec.java](https://codecov.io/gh/apache/pinot/pull/10336?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9NZXRyaWNGaWVsZFNwZWMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ava/org/apache/pinot/spi/stream/StreamMessage.java](https://codecov.io/gh/apache/pinot/pull/10336?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvc3RyZWFtL1N0cmVhbU1lc3NhZ2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...java/org/apache/pinot/common/tier/TierFactory.java](https://codecov.io/gh/apache/pinot/pull/10336?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdGllci9UaWVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1254 more](https://codecov.io/gh/apache/pinot/pull/10336?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on a diff in pull request #10336: [Multistage] Allow queries on multiple tables of same tenant to be executed from controller UI
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on code in PR #10336:
URL: https://github.com/apache/pinot/pull/10336#discussion_r1131943722
##########
pinot-common/src/main/java/org/apache/pinot/common/exception/QueryException.java:
##########
@@ -130,6 +131,8 @@ public static void setMaxLinesOfStackTrace(int maxLinesOfStackTracePerFrame) {
public static final ProcessingException UNKNOWN_COLUMN_ERROR = new ProcessingException(UNKNOWN_COLUMN_ERROR_CODE);
public static final ProcessingException UNKNOWN_ERROR = new ProcessingException(UNKNOWN_ERROR_CODE);
public static final ProcessingException QUOTA_EXCEEDED_ERROR = new ProcessingException(TOO_MANY_REQUESTS_ERROR_CODE);
+ public static final ProcessingException TABLES_NOT_ON_SAME_TENANT_ERROR =
+ new ProcessingException(TABLES_NOT_ON_SAME_TENANT_CODE);
Review Comment:
i dont think we need a new code for this one. let's just use
`BROKER_REQUEST_SEND_ERROR_CODE`
b/c it is actually broker decided not to dispatch the query in the first place
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on a diff in pull request #10336: [Multistage] Allow queries on multiple tables of same tenant to be executed from controller UI
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on code in PR #10336:
URL: https://github.com/apache/pinot/pull/10336#discussion_r1131946143
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##########
@@ -170,10 +171,19 @@ private String getMultiStageQueryResponse(String query, String queryOptions, Htt
return QueryException.ACCESS_DENIED_ERROR.toString();
}
- // Get brokers, only DEFAULT tenant is supported for now.
- // TODO: implement logic that only allows executing query where all accessed tables are within the same tenant.
- List<String> instanceIds = new ArrayList<>(_pinotHelixResourceManager.getAllInstancesForBrokerTenant(
- TagNameUtils.DEFAULT_TENANT_NAME));
+ SqlNodeAndOptions sqlNodeAndOptions = RequestUtils.parseQuery(query);
+ List<String> tableNames = CalciteSqlParser.extractTableNamesFromNode(sqlNodeAndOptions.getSqlNode());
+ if (tableNames.size() == 0) {
+ return QueryException.SQL_PARSING_ERROR.toString();
+ }
+
+ String brokerTenant = getCommonBrokerTenant(tableNames);
+ String serverTenant = getCommonServerTenant(tableNames);
+ if (brokerTenant == null || serverTenant == null) {
+ return QueryException.TABLES_NOT_ON_SAME_TENANT_ERROR.toString();
Review Comment:
```suggestion
if (brokerTenant == null || serverTenant == null) {
return QueryException.getException(QueryException.SQL_PARSING_ERROR, new Exception("Unable to dispatch multistage query with multiple tables on different tenant")).toString();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on a diff in pull request #10336: [Multistage] Allow queries on multiple tables of same tenant to be executed from controller UI
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on code in PR #10336:
URL: https://github.com/apache/pinot/pull/10336#discussion_r1131945053
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestUtils.java:
##########
@@ -48,6 +48,14 @@ public class RequestUtils {
private RequestUtils() {
}
+ public static SqlNodeAndOptions parseQuery(String query)
+ throws SqlCompilationException {
+ long parserStartTimeNs = System.nanoTime();
+ SqlNodeAndOptions sqlNodeAndOptions = CalciteSqlParser.compileToSqlNodeAndOptions(query);
+ sqlNodeAndOptions.setParseTimeNs(System.nanoTime() - parserStartTimeNs);
+ return sqlNodeAndOptions;
+ }
Review Comment:
use a `private static final JsonNode EMPTY_OBJECT_NODE = new ObjectMapper().createObjectNode();`
and reuse the parserQuery API to avoid code copy
```suggestion
return parserQuery(query, EMPTY_OBJECT_NODE);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] tibrewalpratik17 commented on a diff in pull request #10336: [Multistage] Allow queries on multiple tables of same tenant to be executed from controller UI
Posted by "tibrewalpratik17 (via GitHub)" <gi...@apache.org>.
tibrewalpratik17 commented on code in PR #10336:
URL: https://github.com/apache/pinot/pull/10336#discussion_r1118731073
##########
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java:
##########
@@ -135,6 +135,24 @@ public static SqlNodeAndOptions compileToSqlNodeAndOptions(String sql)
}
}
+ public static List<String> extractTableNamesFromNode(SqlNode sqlNode) {
+ List<String> tableNames = new ArrayList<>();
+ if (sqlNode instanceof SqlSelect) {
+ SqlNode fromNode = ((SqlSelect) sqlNode).getFrom();
+ tableNames.addAll(((SqlIdentifier) fromNode).names);
+ tableNames.addAll(extractTableNamesFromNode(((SqlSelect) sqlNode).getWhere()));
+ } else if (sqlNode instanceof SqlBasicCall) {
+ for (SqlNode node: ((SqlBasicCall) sqlNode).getOperandList()) {
+ tableNames.addAll(extractTableNamesFromNode(node));
+ }
+ } else if (sqlNode instanceof SqlOrderBy) {
Review Comment:
There are a lot of extensions of `SqlNode`. I have tried to cover the ones which are hit through most common query patterns. In cases of `SqlDelete`, `SqlCreate` we would hit else clause. In those cases, we would return an empty list for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] tibrewalpratik17 commented on a diff in pull request #10336: [Multistage] Allow queries on multiple tables of same tenant to be executed from controller UI
Posted by "tibrewalpratik17 (via GitHub)" <gi...@apache.org>.
tibrewalpratik17 commented on code in PR #10336:
URL: https://github.com/apache/pinot/pull/10336#discussion_r1119352663
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##########
@@ -170,10 +171,10 @@ private String getMultiStageQueryResponse(String query, String queryOptions, Htt
return QueryException.ACCESS_DENIED_ERROR.toString();
}
- // Get brokers, only DEFAULT tenant is supported for now.
- // TODO: implement logic that only allows executing query where all accessed tables are within the same tenant.
- List<String> instanceIds = new ArrayList<>(_pinotHelixResourceManager.getAllInstancesForBrokerTenant(
- TagNameUtils.DEFAULT_TENANT_NAME));
+ SqlNodeAndOptions sqlNodeAndOptions = RequestUtils.parseQuery(query);
+ List<String> tableNames = CalciteSqlParser.extractTableNamesFromNode(sqlNodeAndOptions.getSqlNode());
+
+ List<String> instanceIds = getCommonInstances(tableNames);
Review Comment:
> Thus my suggestion is should we let's limit the scope to "all tables belong to the same tenant, not necessarily 'default'" first?
This PR takes care of this scenario specifically. At present, queries work fine when we hit brokers directly of a non-default tenant as @ankitsultana mentioned. We want to allow those queries to be pushed down to broker from controller as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] tibrewalpratik17 commented on a diff in pull request #10336: [Multistage] Allow queries on multiple tables of same tenant to be executed from controller UI
Posted by "tibrewalpratik17 (via GitHub)" <gi...@apache.org>.
tibrewalpratik17 commented on code in PR #10336:
URL: https://github.com/apache/pinot/pull/10336#discussion_r1120430373
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##########
@@ -170,10 +171,10 @@ private String getMultiStageQueryResponse(String query, String queryOptions, Htt
return QueryException.ACCESS_DENIED_ERROR.toString();
}
- // Get brokers, only DEFAULT tenant is supported for now.
- // TODO: implement logic that only allows executing query where all accessed tables are within the same tenant.
- List<String> instanceIds = new ArrayList<>(_pinotHelixResourceManager.getAllInstancesForBrokerTenant(
- TagNameUtils.DEFAULT_TENANT_NAME));
+ SqlNodeAndOptions sqlNodeAndOptions = RequestUtils.parseQuery(query);
+ List<String> tableNames = CalciteSqlParser.extractTableNamesFromNode(sqlNodeAndOptions.getSqlNode());
+
+ List<String> instanceIds = getCommonInstances(tableNames);
Review Comment:
I think the issue here is that we are finding common instances for tables and in case of multiple tenants sharing few instances, this can lead to cross-tenant queries. Will use brokerTenant from tableConfig and see if all the tables are under the same tenant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] kishoreg commented on pull request #10336: [Multistage] Allow queries on multiple tables of same tenant to be executed from controller UI
Posted by "kishoreg (via GitHub)" <gi...@apache.org>.
kishoreg commented on PR #10336:
URL: https://github.com/apache/pinot/pull/10336#issuecomment-1505798961
looks like this broke explain
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] ankitsultana commented on pull request #10336: [Multistage] Allow queries on multiple tables of same tenant to be executed from controller UI
Posted by "ankitsultana (via GitHub)" <gi...@apache.org>.
ankitsultana commented on PR #10336:
URL: https://github.com/apache/pinot/pull/10336#issuecomment-1505838082
Yeah this had. @tibrewalpratik17 had merged this which should have fixed it: https://github.com/apache/pinot/pull/10505
Are explain queries still failing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr merged pull request #10336: [Multistage] Allow queries on multiple tables of same tenant to be executed from controller UI
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr merged PR #10336:
URL: https://github.com/apache/pinot/pull/10336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org