[GitHub] [arrow] nealrichardson commented on a change in pull request #7911: ARROW-9606: [C++][Dataset] Support `"a"_.In(<>).Assume()`

[GitBox <gi...@apache.org>]

nealrichardson commented on a change in pull request #7911:
URL: https://github.com/apache/arrow/pull/7911#discussion_r467099186



##########
File path: r/tests/testthat/test-dataset.R
##########
@@ -391,6 +391,17 @@ test_that("filter() with %in%", {
       collect(),
     tibble(int = df1$int[c(3, 4, 6)], part = 1)
   )
+
+  ds <- open_dataset(hive_dir, partitioning = hive_partition(other = utf8(), group = uint8()))

Review comment:
       It's hive-style so you don't need to tell it what the partitions are.
   
   ```suggestion
     ds <- open_dataset(hive_dir)
   ```

##########
File path: r/tests/testthat/test-dataset.R
##########
@@ -391,6 +391,17 @@ test_that("filter() with %in%", {
       collect(),
     tibble(int = df1$int[c(3, 4, 6)], part = 1)
   )
+

Review comment:
       ```suggestion
   
   # ARROW-9606: bug in %in% filter on partition column with >1 partition columns
   ```

##########
File path: r/tests/testthat/test-dataset.R
##########
@@ -391,6 +391,17 @@ test_that("filter() with %in%", {
       collect(),
     tibble(int = df1$int[c(3, 4, 6)], part = 1)
   )
+
+  ds <- open_dataset(hive_dir, partitioning = hive_partition(other = utf8(), group = uint8()))
+  expect_equivalent(
+    ds %>%
+      filter(group %in% c(2)) %>%
+      select(chr, dbl) %>%
+      filter(dbl > 7 & dbl < 53) %>%
+      collect() %>%
+      arrange(dbl),
+    df2[1:2, c("chr", "dbl")]

Review comment:
       A simpler test better shows what this is testing. I confirmed that this fails on master per the user report.
   
   ```suggestion
         filter(group %in% 2) %>%
         collect(),
       df2
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org