You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by hw...@apache.org on 2012/04/26 23:47:51 UTC

svn commit: r1331111 - /subversion/trunk/subversion/libsvn_delta/compat.c

Author: hwright
Date: Thu Apr 26 21:47:50 2012
New Revision: 1331111

URL: http://svn.apache.org/viewvc?rev=1331111&view=rev
Log:
Nuke dead code.

* subversion/libsvn_delta/compat.c
  (add_action): Remove.

Modified:
    subversion/trunk/subversion/libsvn_delta/compat.c

Modified: subversion/trunk/subversion/libsvn_delta/compat.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_delta/compat.c?rev=1331111&r1=1331110&r2=1331111&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_delta/compat.c (original)
+++ subversion/trunk/subversion/libsvn_delta/compat.c Thu Apr 26 21:47:50 2012
@@ -222,36 +222,6 @@ struct change_node
 };
 
 
-static svn_error_t *
-add_action(struct ev2_edit_baton *eb,
-           const char *path,
-           enum action_code_t action,
-           void *args)
-{
-  struct path_action *p_action;
-  apr_array_header_t *action_list = apr_hash_get(eb->paths, path,
-                                                 APR_HASH_KEY_STRING);
-
-  p_action = apr_palloc(eb->edit_pool, sizeof(*p_action));
-  p_action->action = action;
-  p_action->args = args;
-
-  if (action_list == NULL)
-    {
-      const char *path_dup = apr_pstrdup(eb->edit_pool, path);
-
-      action_list = apr_array_make(eb->edit_pool, 1,
-                                   sizeof(struct path_action *));
-      apr_hash_set(eb->paths, path_dup, APR_HASH_KEY_STRING, action_list);
-      APR_ARRAY_PUSH(eb->path_order, const char *) = path_dup;
-    }
-
-  APR_ARRAY_PUSH(action_list, struct path_action *) = p_action;
-
-  return SVN_NO_ERROR;
-}
-
-
 static struct change_node *
 locate_change(struct ev2_edit_baton *eb,
               const char *relpath)



Re: svn commit: r1331111 - /subversion/trunk/subversion/libsvn_delta/compat.c

Posted by Hyrum K Wright <hy...@wandisco.com>.
On Thu, Apr 26, 2012 at 4:54 PM, Greg Stein <gs...@gmail.com> wrote:
> On Thu, Apr 26, 2012 at 17:47,  <hw...@apache.org> wrote:
>> Author: hwright
>> Date: Thu Apr 26 21:47:50 2012
>> New Revision: 1331111
>>
>> URL: http://svn.apache.org/viewvc?rev=1331111&view=rev
>> Log:
>> Nuke dead code.
>>
>> * subversion/libsvn_delta/compat.c
>>  (add_action): Remove.
>
> hehe... you beat me to it :-)
>
> There is more in there that I'll be cleaning out. That "unused"
> function was just the start...

Go for it.  (I was just whacking compiler noise.)

-Hyrum



-- 

uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com/

Re: svn commit: r1331111 - /subversion/trunk/subversion/libsvn_delta/compat.c

Posted by Greg Stein <gs...@gmail.com>.
On Thu, Apr 26, 2012 at 17:47,  <hw...@apache.org> wrote:
> Author: hwright
> Date: Thu Apr 26 21:47:50 2012
> New Revision: 1331111
>
> URL: http://svn.apache.org/viewvc?rev=1331111&view=rev
> Log:
> Nuke dead code.
>
> * subversion/libsvn_delta/compat.c
>  (add_action): Remove.

hehe... you beat me to it :-)

There is more in there that I'll be cleaning out. That "unused"
function was just the start...

Cheers,
-g