You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Qiang Zhang <zh...@zte.com.cn> on 2016/11/01 01:09:13 UTC
Re: Review Request 53298: Wrong method name in the printed error
message
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53298/
-----------------------------------------------------------
(Updated \u5341\u4e00\u6708 1, 2016, 1:09 a.m.)
Review request for ranger, Don Bosco Durai, Ramesh Mani, and Velmurugan Periasamy.
Summary (updated)
-----------------
Wrong method name in the printed error message
Bugs: RANGER-1196
https://issues.apache.org/jira/browse/RANGER-1196
Repository: ranger
Description
-------
java file:KnoxClient.java
Method description error in printing information:"isFileChanged()
public List<String> getTopologyList(String topologyNameMatching,List<String> knoxTopologyList)
{ ... } else { String msgDesc = "Unable to get a valid response for " + "isFileChanged() call for KnoxUrl : [" + knoxUrl + "] - got null response."; ... }
public List<String> getServiceList(String topologyName, String serviceNameMatching, List<String> knoxServiceList) { ... }
else
{ String msgDesc = "Unable to get a valid response for " + "isFileChanged() call for KnoxUrl : [" + knoxUrl + "] - got null response."; ... }
Diffs
-----
knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxClient.java 34f1f86
Diff: https://reviews.apache.org/r/53298/diff/
Testing
-------
A23338432 MINGW64 /f/code/GIT/backup/incubator-ranger (master)
$ git am --signoff < 0001-RANGER-1196.patch
Applying: RANGER-1196
Thanks,
Qiang Zhang
Re: Review Request 53298: Wrong method name in the printed error
message
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53298/#review154531
-----------------------------------------------------------
Ship it!
Ship It!
- Colm O hEigeartaigh
On Nov. 1, 2016, 1:09 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53298/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2016, 1:09 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Ramesh Mani, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1196
> https://issues.apache.org/jira/browse/RANGER-1196
>
>
> Repository: ranger
>
>
> Description
> -------
>
> java file:KnoxClient.java
> Method description error in printing information:"isFileChanged()
> public List<String> getTopologyList(String topologyNameMatching,List<String> knoxTopologyList)
> { ... } else { String msgDesc = "Unable to get a valid response for " + "isFileChanged() call for KnoxUrl : [" + knoxUrl + "] - got null response."; ... }
>
> public List<String> getServiceList(String topologyName, String serviceNameMatching, List<String> knoxServiceList) { ... }
> else
> { String msgDesc = "Unable to get a valid response for " + "isFileChanged() call for KnoxUrl : [" + knoxUrl + "] - got null response."; ... }
>
>
> Diffs
> -----
>
> knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxClient.java 34f1f86
>
> Diff: https://reviews.apache.org/r/53298/diff/
>
>
> Testing
> -------
>
> A23338432 MINGW64 /f/code/GIT/backup/incubator-ranger (master)
> $ git am --signoff < 0001-RANGER-1196.patch
> Applying: RANGER-1196
>
>
> Thanks,
>
> Qiang Zhang
>
>