You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by de...@apache.org on 2018/12/16 11:37:36 UTC

svn commit: r1849021 - in /ofbiz/ofbiz-framework/trunk/applications/party: webapp/partymgr/WEB-INF/controller.xml widget/partymgr/PartyScreens.xml

Author: deepak
Date: Sun Dec 16 11:37:36 2018
New Revision: 1849021

URL: http://svn.apache.org/viewvc?rev=1849021&view=rev
Log:
Improved: request map to create party content in controller.xml exists twice
(OFBIZ-10699)
Renamed ambiguous controller request CreatePartyContent to EditPartyContent as per OOTB pattern.
Thanks Pierre Smits for reporting the issue and Jacques Le Roux for the the details and discussion

Modified:
    ofbiz/ofbiz-framework/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml
    ofbiz/ofbiz-framework/trunk/applications/party/widget/partymgr/PartyScreens.xml

Modified: ofbiz/ofbiz-framework/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml?rev=1849021&r1=1849020&r2=1849021&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml (original)
+++ ofbiz/ofbiz-framework/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml Sun Dec 16 11:37:36 2018
@@ -954,9 +954,9 @@ under the License.
     </request-map>
 
     <!-- Create and Upload Party Content -->
-    <request-map uri="CreatePartyContent">
+    <request-map uri="EditPartyContent">
         <security auth="true" https="true"/>
-        <response name="success" type="view" value="CreatePartyContent"/>
+        <response name="success" type="view" value="EditPartyContent"/>
     </request-map>
     <request-map uri="EditPartyContents">
         <security auth="true" https="true"/>
@@ -1441,7 +1441,7 @@ under the License.
     <view-map name="PartyExportCsv" type="screencsv" page="component://party/widget/partymgr/PartyScreens.xml#PartyExportCsv" content-type="text/csv" encoding="none"/>
 
     <view-map name="EditPartyContents" type="screen" page="component://party/widget/partymgr/PartyScreens.xml#EditPartyContents"/>
-    <view-map name="CreatePartyContent" type="screen" page="component://party/widget/partymgr/PartyScreens.xml#CreatePartyContent"/>
+    <view-map name="EditPartyContent" type="screen" page="component://party/widget/partymgr/PartyScreens.xml#EditPartyContent"/>
     <view-map name="editCarrierAccount" type="screen" page="component://party/widget/partymgr/PartyScreens.xml#editCarrierAccount"/>
     <view-map name="partyInvitation" type="screen" page="component://party/widget/partymgr/PartyInvitationScreens.xml#FindPartyInvitations"/>
     <view-map name="editPartyInvitation" type="screen" page="component://party/widget/partymgr/PartyInvitationScreens.xml#EditPartyInvitation"/>

Modified: ofbiz/ofbiz-framework/trunk/applications/party/widget/partymgr/PartyScreens.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/party/widget/partymgr/PartyScreens.xml?rev=1849021&r1=1849020&r2=1849021&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/party/widget/partymgr/PartyScreens.xml (original)
+++ ofbiz/ofbiz-framework/trunk/applications/party/widget/partymgr/PartyScreens.xml Sun Dec 16 11:37:36 2018
@@ -915,7 +915,7 @@ under the License.
                 <decorator-screen name="CommonPartyDecorator"  location="${parameters.mainDecoratorLocation}">
                     <decorator-section name="body">
                         <container style="button-bar">
-                            <link target="CreatePartyContent" text="${uiLabelMap.CommonCreateNew}" style="smallSubmit">
+                            <link target="EditPartyContent" text="${uiLabelMap.CommonCreateNew}" style="smallSubmit">
                                 <parameter param-name="partyId"/>
                             </link>
                         </container>
@@ -930,7 +930,7 @@ under the License.
             </widgets>
         </section>
     </screen>
-    <screen name="CreatePartyContent">
+    <screen name="EditPartyContent">
         <section>
             <actions>
                 <set field="titleProperty" value="PageTitleListContent"/>
@@ -942,7 +942,7 @@ under the License.
                 <decorator-screen name="CommonPartyDecorator"  location="${parameters.mainDecoratorLocation}">
                     <decorator-section name="body">
                         <container style="button-bar">
-                            <link target="CreatePartyContent" text="${uiLabelMap.CommonCreateNew}" style="smallSubmit">
+                            <link target="EditPartyContent" text="${uiLabelMap.CommonCreateNew}" style="smallSubmit">
                                 <parameter param-name="partyId"/>
                             </link>
                         </container>