Bugs

[Jim Larus <la...@microsoft.com>]

I'm porting the Cloudstone benchmark to Microsoft ASP.NET and Azure.
I'm starting from the PHP version and I'm confused by some of the DB manipulations in addEventResult.php. They don't seem correct:

1.      At Step 3 (line 56+), the code adds an address to the DB without checking if it is already present. This seems inconsistent at best with the rest of the DB manipulations and incorrect at worst. I understand the performance motivation for this decision, but want to make sure it is intentional.

2.      The tag manipulation at Step 5 (line 123+) for updating an event doesn't iterate over the tags entered in the webpage. The iteration is commented out. Why?
Thanks in advance for your assistance,
/Jim

James Larus
Microsoft Research

Re: Bugs

[Akara Sucharitakul <Ak...@Sun.COM>]

Jim Larus wrote:
> I'm porting the Cloudstone benchmark to Microsoft ASP.NET and Azure.
> I'm starting from the PHP version and I'm confused by some of the DB manipulations in addEventResult.php. They don't seem correct:
> 
> 1.      At Step 3 (line 56+), the code adds an address to the DB without checking if it is already present. This seems inconsistent at best with the rest of the DB manipulations and incorrect at worst. I understand the performance motivation for this decision, but want to make sure it is intentional.

Yes, you understood it correctly. Matching addresses is a trick by 
itself. Even the same address often does not match if you try to compare 
it line by line. It will need some form of normalization and should be 
done off-line. Also matching all the fields of the address requires 
excessive indexing. So it is better to denormalize this part of the DB 
for better response times.
> 
> 2.      The tag manipulation at Step 5 (line 123+) for updating an event doesn't iterate over the tags entered in the webpage. The iteration is commented out. Why?

Hmmm, I'm not sure the code I'm looking at matches yours. The lines 
don't seem to correspond. Based on my code, the whole step 5 is in a big 
foreach loop that iterates over all the tags (foreach ($tagList as 
$tag)). Can you please check out the latest code for this?

Thanks!
-Akara