You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/07/13 02:13:14 UTC
[GitHub] [shardingsphere] xuup opened a new pull request, #19081: Add test case for OptimizerContext.addSchema()#18682
xuup opened a new pull request, #19081:
URL: https://github.com/apache/shardingsphere/pull/19081
Fixes #18682 .
Changes proposed in this pull request:
- add test case for OptimizerContext.addSchema()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #19081: Add test case for OptimizerContext.addSchema()#18682
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #19081:
URL: https://github.com/apache/shardingsphere/pull/19081#issuecomment-1182730598
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/19081?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19081](https://codecov.io/gh/apache/shardingsphere/pull/19081?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a7f4f52) into [master](https://codecov.io/gh/apache/shardingsphere/commit/df0fa347f8e0d8cd1b7cd5b04eb0067bcd8b0ca6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (df0fa34) will **increase** coverage by `0.01%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head a7f4f52 differs from pull request most recent head dc1e0f8. Consider uploading reports for the commit dc1e0f8 to get more accurate results
```diff
@@ Coverage Diff @@
## master #19081 +/- ##
============================================
+ Coverage 59.38% 59.39% +0.01%
Complexity 2320 2320
============================================
Files 3804 3803 -1
Lines 54711 54706 -5
Branches 9225 9225
============================================
+ Hits 32492 32495 +3
+ Misses 19500 19492 -8
Partials 2719 2719
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/19081?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../shardingsphere/infra/check/SQLCheckException.java](https://codecov.io/gh/apache/shardingsphere/pull/19081/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9jaGVjay9TUUxDaGVja0V4Y2VwdGlvbi5qYXZh) | `0.00% <ø> (ø)` | |
| [...ingsphere/infra/exception/NoDatabaseException.java](https://codecov.io/gh/apache/shardingsphere/pull/19081/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9leGNlcHRpb24vTm9EYXRhYmFzZUV4Y2VwdGlvbi5qYXZh) | `0.00% <ø> (ø)` | |
| [...metadata/database/schema/event/DropIndexEvent.java](https://codecov.io/gh/apache/shardingsphere/pull/19081/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9kYXRhYmFzZS9zY2hlbWEvZXZlbnQvRHJvcEluZGV4RXZlbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...dingsphere/driver/executor/DriverJDBCExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/19081/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9leGVjdXRvci9Ecml2ZXJKREJDRXhlY3V0b3IuamF2YQ==) | `87.50% <ø> (ø)` | |
| [...uit/statement/CircuitBreakerPreparedStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/19081/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9zdGF0ZS9jaXJjdWl0L3N0YXRlbWVudC9DaXJjdWl0QnJlYWtlclByZXBhcmVkU3RhdGVtZW50LmphdmE=) | `1.69% <ø> (ø)` | |
| [...ate/circuit/statement/CircuitBreakerStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/19081/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9zdGF0ZS9jaXJjdWl0L3N0YXRlbWVudC9DaXJjdWl0QnJlYWtlclN0YXRlbWVudC5qYXZh) | `2.70% <ø> (ø)` | |
| [.../shardingsphere/authority/model/PrivilegeType.java](https://codecov.io/gh/apache/shardingsphere/pull/19081/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWF1dGhvcml0eS9zaGFyZGluZ3NwaGVyZS1hdXRob3JpdHktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hdXRob3JpdHkvbW9kZWwvUHJpdmlsZWdlVHlwZS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../core/metadata/generator/PipelineDDLGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/19081/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2NvcmUvbWV0YWRhdGEvZ2VuZXJhdG9yL1BpcGVsaW5lRERMR2VuZXJhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...sql/ddlgenerator/MySQLCreateTableSQLGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/19081/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1kaWFsZWN0L3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvbXlzcWwvZGRsZ2VuZXJhdG9yL015U1FMQ3JlYXRlVGFibGVTUUxHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ddlgenerator/OpenGaussCreateTableSQLGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/19081/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1kaWFsZWN0L3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUtb3BlbmdhdXNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL29wZW5nYXVzcy9kZGxnZW5lcmF0b3IvT3BlbkdhdXNzQ3JlYXRlVGFibGVTUUxHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/shardingsphere/pull/19081/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/19081?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/19081?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [df0fa34...dc1e0f8](https://codecov.io/gh/apache/shardingsphere/pull/19081?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] xuup closed pull request #19081: Add test case for OptimizerContext.addSchema()#18682
Posted by GitBox <gi...@apache.org>.
xuup closed pull request #19081: Add test case for OptimizerContext.addSchema()#18682
URL: https://github.com/apache/shardingsphere/pull/19081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a diff in pull request #19081: Add test case for OptimizerContext.addSchema()#18682
Posted by GitBox <gi...@apache.org>.
terrymanu commented on code in PR #19081:
URL: https://github.com/apache/shardingsphere/pull/19081#discussion_r919620506
##########
shardingsphere-infra/shardingsphere-infra-federation/shardingsphere-infra-federation-optimizer/src/test/java/org/apache/shardingsphere/infra/federation/optimizer/context/OptimizerContextTest.java:
##########
@@ -86,7 +86,15 @@ public void assertAlterDatabase() {
assertTrue(schemaMetadata.isPresent());
assertTrue(schemaMetadata.get().getTables().containsKey("bar_tbl"));
}
-
+
+ @Test
+ public void assertAddSchema() {
+ OptimizerContext optimizerContext = createOptimizerContext();
+ assertFalse(optimizerContext.getFederationMetaData().getDatabases().get("foo_db").getSchemaMetadata("foo_schema_ts").isPresent());
Review Comment:
Is it necessary to assert expect value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org