You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/02/04 00:43:16 UTC

[GitHub] [incubator-yunikorn-k8shim] yangwwei opened a new pull request #230: [YUNIKORN-538] Scheduler is unable to recovery from a restart.

yangwwei opened a new pull request #230:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/230


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #230: [YUNIKORN-538] Scheduler is unable to recovery from a restart.

Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #230:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/230#issuecomment-773520050


   > This test uses 3 different ways to test for a nil error value:
   > 
   > 1. assert.Assert(t, err == nil)
   > 2. assert.Equal(t, err, nil)
   > 3. assert.NilError(t, err,...)
   > 
   > Should be using `assert.NilError()` consistently in the test.
   
   Thanks, fixed in the latest commit.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #230: [YUNIKORN-538] Scheduler is unable to recovery from a restart.

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #230:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/230#issuecomment-772939882






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #230: [YUNIKORN-538] Scheduler is unable to recovery from a restart.

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #230:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/230#issuecomment-772939882


   # [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/230?src=pr&el=h1) Report
   > Merging [#230](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/230?src=pr&el=desc) (300fb47) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/c47ed51f075c5af5910f71da40e7e68699a9abae?el=desc) (c47ed51) will **decrease** coverage by `0.16%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/230/graphs/tree.svg?width=650&height=150&src=pr&token=LZImIuvleR)](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/230?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #230      +/-   ##
   ==========================================
   - Coverage   59.75%   59.59%   -0.17%     
   ==========================================
     Files          35       35              
     Lines        3133     3128       -5     
   ==========================================
   - Hits         1872     1864       -8     
   - Misses       1180     1182       +2     
   - Partials       81       82       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/230?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [pkg/cache/application.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/230/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `77.60% <100.00%> (+0.86%)` | :arrow_up: |
   | [pkg/cache/task.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/230/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `70.40% <0.00%> (-4.00%)` | :arrow_down: |
   | [pkg/cache/placeholder\_manager.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/230/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3BsYWNlaG9sZGVyX21hbmFnZXIuZ28=) | `79.36% <0.00%> (-0.33%)` | :arrow_down: |
   | [...missioncontrollers/webhook/admission\_controller.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/230/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL2FkbWlzc2lvbl9jb250cm9sbGVyLmdv) | `33.74% <0.00%> (+1.00%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/230?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/230?src=pr&el=footer). Last update [d8f8921...300fb47](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/230?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] wilfred-s closed pull request #230: [YUNIKORN-538] Scheduler is unable to recovery from a restart.

Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #230:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/230


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #230: [YUNIKORN-538] Scheduler is unable to recovery from a restart.

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #230:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/230#issuecomment-772939882


   # [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/230?src=pr&el=h1) Report
   > Merging [#230](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/230?src=pr&el=desc) (04587a2) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/c47ed51f075c5af5910f71da40e7e68699a9abae?el=desc) (c47ed51) will **decrease** coverage by `0.25%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/230/graphs/tree.svg?width=650&height=150&src=pr&token=LZImIuvleR)](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/230?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #230      +/-   ##
   ==========================================
   - Coverage   59.75%   59.49%   -0.26%     
   ==========================================
     Files          35       35              
     Lines        3133     3133              
   ==========================================
   - Hits         1872     1864       -8     
   - Misses       1180     1187       +7     
   - Partials       81       82       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/230?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [pkg/cache/application.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/230/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `77.60% <100.00%> (+0.86%)` | :arrow_up: |
   | [pkg/cache/task.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/230/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `70.40% <0.00%> (-4.00%)` | :arrow_down: |
   | [pkg/cache/placeholder\_manager.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/230/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3BsYWNlaG9sZGVyX21hbmFnZXIuZ28=) | `79.36% <0.00%> (-0.33%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/230?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/230?src=pr&el=footer). Last update [d8f8921...04587a2](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/230?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #230: [YUNIKORN-538] Scheduler is unable to recovery from a restart.

Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #230:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/230#issuecomment-773520050


   > This test uses 3 different ways to test for a nil error value:
   > 
   > 1. assert.Assert(t, err == nil)
   > 2. assert.Equal(t, err, nil)
   > 3. assert.NilError(t, err,...)
   > 
   > Should be using `assert.NilError()` consistently in the test.
   
   Thanks, fixed in the latest commit.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #230: [YUNIKORN-538] Scheduler is unable to recovery from a restart.

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #230:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/230#issuecomment-772939882


   # [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/230?src=pr&el=h1) Report
   > Merging [#230](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/230?src=pr&el=desc) (04587a2) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/c47ed51f075c5af5910f71da40e7e68699a9abae?el=desc) (c47ed51) will **decrease** coverage by `0.25%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/230/graphs/tree.svg?width=650&height=150&src=pr&token=LZImIuvleR)](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/230?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #230      +/-   ##
   ==========================================
   - Coverage   59.75%   59.49%   -0.26%     
   ==========================================
     Files          35       35              
     Lines        3133     3133              
   ==========================================
   - Hits         1872     1864       -8     
   - Misses       1180     1187       +7     
   - Partials       81       82       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/230?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [pkg/cache/application.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/230/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `77.60% <100.00%> (+0.86%)` | :arrow_up: |
   | [pkg/cache/task.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/230/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `70.40% <0.00%> (-4.00%)` | :arrow_down: |
   | [pkg/cache/placeholder\_manager.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/230/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3BsYWNlaG9sZGVyX21hbmFnZXIuZ28=) | `79.36% <0.00%> (-0.33%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/230?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/230?src=pr&el=footer). Last update [d8f8921...300fb47](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/230?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] wilfred-s closed pull request #230: [YUNIKORN-538] Scheduler is unable to recovery from a restart.

Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #230:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/230


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org