[GitHub] [incubator-dolphinscheduler] lenboo commented on a change in pull request #4654: [Feature][JsonSplit] add task delete/update/switch method

[GitBox <gi...@apache.org>]

lenboo commented on a change in pull request #4654:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4654#discussion_r568299687



##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java
##########
@@ -100,14 +111,8 @@
         }
 
         TaskNode taskNode = JSONUtils.parseObject(taskDefinitionJson, TaskNode.class);
-        if (taskNode == null) {
-            logger.error("taskDefinitionJson is not valid json");
-            putMsg(result, Status.DATA_IS_NOT_VALID, taskDefinitionJson);
-            return result;
-        }
-        if (!CheckUtils.checkTaskNodeParameters(taskNode.getParams(), taskNode.getName())) {
-            logger.error("task node {} parameter invalid", taskNode.getName());
-            putMsg(result, Status.PROCESS_NODE_S_PARAMETER_INVALID, taskNode.getName());
+        checkTaskNode(result, taskNode, taskDefinitionJson);

Review comment:
       missing 'result = ？'




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org