You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "cshannon (via GitHub)" <gi...@apache.org> on 2023/03/24 17:35:02 UTC

[GitHub] [accumulo] cshannon commented on pull request #3257: Refactor TabletMetadata.Location to encapsulate TServerInstance

cshannon commented on PR #3257:
URL: https://github.com/apache/accumulo/pull/3257#issuecomment-1483174285

   @keith-turner  - I went ahead and targeted this for 2.1.1 since it's not public APIs but that could be changed. I updated the Ample interface to pass in a Location instead of the tserver and location type. If we want we could keep backwards compatibility by adding some default methods that delegate to the new methods, for example: 
   
   ```java
   default T putLocation(TServerInstance tserver, TabletMetadata.LocationType type) {
     return putLocation(new TabletMetadata.Location(tserver, type));
   }
   
   default T deleteLocation(TServerInstance tserver, TabletMetadata.LocationType type) {
     return putLocation(new TabletMetadata.Location(tserver, type));
   }
   ```
   
   But I did not do that for now as I figured it would be cleaner to just change the existing. Also, I didn't add any new tests because all of the existing tests seem to have enough coverage. I ran through the Sunny ITs and everything passed and I can kick off a full IT. I also grabbed your branch from #3251 locally and merged this in and after fixing the merge conflicts I verified the TabletMetadataTest still passed with the new update.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org