You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/02 17:52:28 UTC

[GitHub] [spark] rednaxelafx commented on pull request #30570: [SPARK-33544][SQL][FOLLOW-UP] Rename NoSideEffect to NoThrow and clarify the documentation more

rednaxelafx commented on pull request #30570:
URL: https://github.com/apache/spark/pull/30570#issuecomment-737392973


   Late LGTM, thank you very much for helping to make the semantics more explicit! It's nice to have a marker trait for `NoThrow`.
   
   I had been thinking about the constraint expressions like `KnownNotNull` that wraps around an existing expression, but that's for dynamically annotating an expression for extra properties. In the case of `NoThrow`, it's statically known from the type so an empty marker trait as-is makes more sense.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org