You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "xingfudeshi (via GitHub)" <gi...@apache.org> on 2025/12/11 01:54:59 UTC
[PR] optimize:upgrade min-document to version 2.9.1 or later [incubator-seata]
xingfudeshi opened a new pull request, #7849:
URL: https://github.com/apache/incubator-seata/pull/7849
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<!-- Please make sure you have read and understood the contributing guidelines -->
- [ ] I have read the [CONTRIBUTING.md](https://github.com/apache/incubator-seata/blob/2.x/CONTRIBUTING.md) guidelines.
- [ ] I have registered the PR [changes](https://github.com/apache/incubator-seata/tree/2.x/changes).
### Ⅰ. Describe what this PR did
Upgrade min-document to version 2.9.1 or later
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
fixes #7848
### Ⅲ. Why don't you add test cases (unit test/integration test)?
### Ⅳ. Describe how to verify it
### Ⅴ. Special notes for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize:upgrade min-document to version 2.9.1 or later [incubator-seata]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #7849:
URL: https://github.com/apache/incubator-seata/pull/7849#discussion_r2608846277
##########
console/src/main/resources/static/console-fe/package.json:
##########
@@ -110,6 +110,7 @@
"braces": "3.0.3",
"micromatch": "4.0.8",
"serialize-javascript": "6.0.2",
- "node-forge": "^1.3.3"
+ "node-forge": "^1.3.3",
+ "min-document": "^2.19.1"
Review Comment:
The PR description mentions upgrading to "version 2.9.1 or later" but the actual version being specified in the code is "^2.19.1" (note: 2.19.1, not 2.9.1). This appears to be a typo in the PR description. The version in the code is correct - min-document 2.19.1+ addresses the security vulnerability, and the package-lock.json correctly shows version 2.19.2 being installed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize:upgrade min-document to version 2.9.1 or later [incubator-seata]
Posted by "xingfudeshi (via GitHub)" <gi...@apache.org>.
xingfudeshi commented on code in PR #7849:
URL: https://github.com/apache/incubator-seata/pull/7849#discussion_r2616149935
##########
changes/zh-cn/2.x.md:
##########
@@ -94,6 +94,7 @@
- [[#7716](https://github.com/apache/incubator-seata/pull/7716)] 升级 commons-lang 为 3.18.0
- [[#7699](https://github.com/apache/incubator-seata/pull/7699)] 升级axios到1.12.2
- [[#7845](https://github.com/apache/incubator-seata/pull/7845)] 升级node-forge到1.3.2以上
+- [[#7849](https://github.com/apache/incubator-seata/pull/7849)] 升级min-document到2.9.1以上
Review Comment:
You are right, My fault.😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize:upgrade min-document to version 2.19.1 or later [incubator-seata]
Posted by "xingfudeshi (via GitHub)" <gi...@apache.org>.
xingfudeshi commented on PR #7849:
URL: https://github.com/apache/incubator-seata/pull/7849#issuecomment-3649098101
@YongGoose All done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize:upgrade min-document to version 2.9.1 or later [incubator-seata]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7849:
URL: https://github.com/apache/incubator-seata/pull/7849#issuecomment-3639745832
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/7849?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 70.89%. Comparing base ([`3ddb97a`](https://app.codecov.io/gh/apache/incubator-seata/commit/3ddb97a2e2faa79e53294f28885534a4c027f1d2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9c203a7`](https://app.codecov.io/gh/apache/incubator-seata/commit/9c203a72e9e3c0a8c0fb93be5a41bbc569da79d7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 2.x #7849 +/- ##
============================================
- Coverage 70.91% 70.89% -0.03%
Complexity 992 992
============================================
Files 1322 1322
Lines 50322 50322
Branches 5946 5946
============================================
- Hits 35688 35674 -14
- Misses 11683 11698 +15
+ Partials 2951 2950 -1
```
[see 5 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/7849/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
[](https://app.codecov.io/gh/apache/incubator-seata/pull/7849?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize:upgrade min-document to version 2.19.1 or later [incubator-seata]
Posted by "xingfudeshi (via GitHub)" <gi...@apache.org>.
xingfudeshi merged PR #7849:
URL: https://github.com/apache/incubator-seata/pull/7849
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize:upgrade min-document to version 2.19.1 or later [incubator-seata]
Posted by "xingfudeshi (via GitHub)" <gi...@apache.org>.
xingfudeshi commented on PR #7849:
URL: https://github.com/apache/incubator-seata/pull/7849#issuecomment-3649105893
> LGTM 🚀
>
>
>
> Please resolve coflicts 😅
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize:upgrade min-document to version 2.9.1 or later [incubator-seata]
Posted by "YongGoose (via GitHub)" <gi...@apache.org>.
YongGoose commented on code in PR #7849:
URL: https://github.com/apache/incubator-seata/pull/7849#discussion_r2616146643
##########
changes/zh-cn/2.x.md:
##########
@@ -94,6 +94,7 @@
- [[#7716](https://github.com/apache/incubator-seata/pull/7716)] 升级 commons-lang 为 3.18.0
- [[#7699](https://github.com/apache/incubator-seata/pull/7699)] 升级axios到1.12.2
- [[#7845](https://github.com/apache/incubator-seata/pull/7845)] 升级node-forge到1.3.2以上
+- [[#7849](https://github.com/apache/incubator-seata/pull/7849)] 升级min-document到2.9.1以上
Review Comment:
Shouldn’t it be 2.19.1 instead of 2.9.1? 😂
##########
changes/en-us/2.x.md:
##########
@@ -96,6 +96,7 @@ Add changes here for all PR submitted to the 2.x branch.
- [[#7716](https://github.com/apache/incubator-seata/pull/7716)] Update commons-lang to 3.18.0
- [[#7699](https://github.com/apache/incubator-seata/pull/7699)] Upgrade axios to version 1.12.2
- [[#7845](https://github.com/apache/incubator-seata/pull/7845)] upgrade node-forge to version 1.3.2 or later
+- [[#7849](https://github.com/apache/incubator-seata/pull/7849)] upgrade min-document to version 2.9.1 or later
Review Comment:
Ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org