You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Stefan Küng <to...@gmail.com> on 2005/12/27 08:58:16 UTC
Problem with svn_client_ls3 and pre 1.2 servers
Hi,
This isn't a problem with the CL client but with the library, I haven't
found a way to reproduce this with the client (yet).
While trying to reproduce some reports on the TSVN list, I found that
when doing an svn_client_ls3() with a pre-1.2 server and TSVN linked
against the very latest 1.3.x branch, I get an error which shouldn't happen.
svn_client_ls3(&hash,
%lockhash,
"http://vss2svn.tigris.org/svn/vss2svn/branches/0.3-bugfix",
pegrev,
rev,
false,
pctx,
subpool);
with pegrev and rev being 52, both hashes created with apr_hash_make()
and pctx also set up correctly.
This will return the error:
REPORT request failed on 'url'
'url' path not found.
While stepping through the Subversion code, I found that the 'ls' part
works correctly but then fails when it tries to fetch the locks. This is
of course not a problem because tigris.org is a pre-1.2 server and
simply doesn't know about locks. The problem is that in
libsvn_client/ls.c, lines 158ff. the returned error isn't
SVN_ERR_RA_NOT_IMPLEMENTED but 175007, and that error isn't caught.
Stefan
P.S. Just found the '-v' option :)
svn ls -v http://vss2svn.tigris.org/svn/vss2svn/branches/0.3-bugfix@52
will fail, but
svn ls http://vss2svn.tigris.org/svn/vss2svn/branches/0.3-bugfix@52
works.
svn --version
svn, version 1.3.0 (dev build)
compiled Dec 20 2005, 18:13:18
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Problem with svn_client_ls3 and pre 1.2 servers
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On 1/3/06, Ben Collins-Sussman <su...@red-bean.com> wrote:
> Gah, then we definitely should propose it for 1.3.1. 'svn ls -v shows
> locks' is supposed to be a new 1.3 feature.
Well, the showing locks still works normally, this is just a problem
when using peg revisions and paths that have been deleted, at least if
it's really issue 2442 that's the root cause.
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Problem with svn_client_ls3 and pre 1.2 servers
Posted by Ben Collins-Sussman <su...@red-bean.com>.
Gah, then we definitely should propose it for 1.3.1. 'svn ls -v shows
locks' is supposed to be a new 1.3 feature.
On 1/3/06, Garrett Rooney <ro...@electricjellyfish.net> wrote:
> On 12/27/05, Stefan Küng <to...@gmail.com> wrote:
>
> > While stepping through the Subversion code, I found that the 'ls' part
> > works correctly but then fails when it tries to fetch the locks. This is
> > of course not a problem because tigris.org is a pre-1.2 server and
> > simply doesn't know about locks. The problem is that in
> > libsvn_client/ls.c, lines 158ff. the returned error isn't
> > SVN_ERR_RA_NOT_IMPLEMENTED but 175007, and that error isn't caught.
>
> I believe that is issue #2442, I committed a fix for it in r17485, but
> I don't believe it was backported to 1.3.x.
>
> -garrett
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Problem with svn_client_ls3 and pre 1.2 servers
Posted by Stefan Küng <to...@gmail.com>.
Garrett Rooney wrote:
> On 12/27/05, Stefan Küng <to...@gmail.com> wrote:
>
>> While stepping through the Subversion code, I found that the 'ls' part
>> works correctly but then fails when it tries to fetch the locks. This is
>> of course not a problem because tigris.org is a pre-1.2 server and
>> simply doesn't know about locks. The problem is that in
>> libsvn_client/ls.c, lines 158ff. the returned error isn't
>> SVN_ERR_RA_NOT_IMPLEMENTED but 175007, and that error isn't caught.
>
> I believe that is issue #2442, I committed a fix for it in r17485, but
> I don't believe it was backported to 1.3.x.
I can confirm that it is fixed in HEAD on trunk. But I really don't know
in which revision it got fixed or if it's really issue #2442.
If it is r17485, can you maybe nominate it for backporting?
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Problem with svn_client_ls3 and pre 1.2 servers
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On 12/27/05, Stefan Küng <to...@gmail.com> wrote:
> While stepping through the Subversion code, I found that the 'ls' part
> works correctly but then fails when it tries to fetch the locks. This is
> of course not a problem because tigris.org is a pre-1.2 server and
> simply doesn't know about locks. The problem is that in
> libsvn_client/ls.c, lines 158ff. the returned error isn't
> SVN_ERR_RA_NOT_IMPLEMENTED but 175007, and that error isn't caught.
I believe that is issue #2442, I committed a fix for it in r17485, but
I don't believe it was backported to 1.3.x.
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org