You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/06 01:39:43 UTC
[GitHub] [airflow] ryanahamilton opened a new pull request #15277: Remove support for FAB `APP_THEME`
ryanahamilton opened a new pull request #15277:
URL: https://github.com/apache/airflow/pull/15277
Resolves #13158.
As the UI has evolved, it has needed to diverge from the constraints of the aged, secondary Bootstrap dependency (by way of FAB). The alternative Bootstrap themes provided by FAB are no longer working properly, resulting in a sub-par user experience for anyone who might opt to use one. Supporting these themes would require substantial ongoing maintenance overhead.
The alternative themes don't provide a better user experience than the (newly refreshed) UI theme. I could see differentiation between multiple Airflow deployments as the goal for utilizing this feature. In that case, we have the option to set a different nav bar color by setting a color value in the `navbar_color` config.
While this PR doesn't stop a user (who knows the inner workings of FAB) from configuring an alternative theme, it does ensure that the airflow theme is always loaded. There is no documentation of this feature in the Airflow docs, but this PR also removes comments suggesting usage of it and pointing to the FAB docs.
I've also updated the theme CSS file naming to remove "default" so it doesn't suggest that it is something changeable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15277: Remove support for FAB `APP_THEME`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15277:
URL: https://github.com/apache/airflow/pull/15277#issuecomment-995313717
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #15277: Remove support for FAB `APP_THEME`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #15277:
URL: https://github.com/apache/airflow/pull/15277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15277: Remove support for FAB `APP_THEME`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15277:
URL: https://github.com/apache/airflow/pull/15277#issuecomment-1076937603
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15277: Remove support for FAB `APP_THEME`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15277:
URL: https://github.com/apache/airflow/pull/15277#issuecomment-955610920
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15277: Remove support for FAB `APP_THEME`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15277:
URL: https://github.com/apache/airflow/pull/15277#issuecomment-919595241
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton commented on pull request #15277: Remove support for FAB `APP_THEME`
Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on pull request #15277:
URL: https://github.com/apache/airflow/pull/15277#issuecomment-817885267
This feature removal needs to wait for 3.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15277: Remove support for FAB `APP_THEME`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15277:
URL: https://github.com/apache/airflow/pull/15277#issuecomment-850022630
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15277: Remove support for FAB `APP_THEME`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15277:
URL: https://github.com/apache/airflow/pull/15277#issuecomment-890259909
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15277: Remove support for FAB `APP_THEME`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15277:
URL: https://github.com/apache/airflow/pull/15277#issuecomment-1025266750
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #15277: Remove support for FAB `APP_THEME`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #15277:
URL: https://github.com/apache/airflow/pull/15277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org