You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/23 14:58:35 UTC
[GitHub] [arrow] nealrichardson opened a new pull request, #13429: ARROW-16895: [R] Fix cmake version detection
nealrichardson opened a new pull request, #13429:
URL: https://github.com/apache/arrow/pull/13429
Discovered in https://github.com/apache/arrow/issues/13425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #13429: ARROW-16895: [R] Fix cmake version detection
Posted by GitBox <gi...@apache.org>.
kou merged PR #13429:
URL: https://github.com/apache/arrow/pull/13429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on a diff in pull request #13429: ARROW-16895: [R] Fix cmake version detection
Posted by GitBox <gi...@apache.org>.
raulcd commented on code in PR #13429:
URL: https://github.com/apache/arrow/pull/13429#discussion_r905370176
##########
r/tools/nixlibs.R:
##########
@@ -404,8 +404,10 @@ ensure_cmake <- function() {
cmake
}
-find_cmake <- function(paths, version_required = 3.10) {
+find_cmake <- function(paths, version_required = "3.10") {
# Given a list of possible cmake paths, return the first one that exists and is new enough
+ # version_required should be a strong or packageVersion; numeric version
Review Comment:
```suggestion
# version_required should be a string or packageVersion; numeric version
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a diff in pull request #13429: ARROW-16895: [R] Fix cmake version detection
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on code in PR #13429:
URL: https://github.com/apache/arrow/pull/13429#discussion_r905470325
##########
r/tools/nixlibs.R:
##########
@@ -404,8 +404,10 @@ ensure_cmake <- function() {
cmake
}
-find_cmake <- function(paths, version_required = 3.10) {
+find_cmake <- function(paths, version_required = "3.10") {
# Given a list of possible cmake paths, return the first one that exists and is new enough
+ # version_required should be a strong or packageVersion; numeric version
Review Comment:
oof thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13429: ARROW-16895: [R] Fix cmake version detection
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13429:
URL: https://github.com/apache/arrow/pull/13429#issuecomment-1164518240
https://issues.apache.org/jira/browse/ARROW-16895
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org