[GitHub] [flink] aljoscha commented on a change in pull request #14793: [FLINK-21182] Make HeapPriorityQueueStateSnapshot iterable

[GitBox <gi...@apache.org>]

aljoscha commented on a change in pull request #14793:
URL: https://github.com/apache/flink/pull/14793#discussion_r566226279



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyGroupPartitioner.java
##########
@@ -125,9 +123,10 @@ public KeyGroupPartitioner(
     }
 
     /**
-     * Partitions the data into key-groups and returns the result via {@link PartitioningResult}.
+     * Partitions the data into key-groups and returns the result via {@link
+     * PartitioningResultImpl}.

Review comment:
       ```suggestion
        * Partitions the data into key-groups and returns the result as a {@link
        * PartitioningResult}.
   ```

##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/state/KeyGroupPartitionerTestBase.java
##########
@@ -65,7 +77,57 @@ public void testPartitionByKeyGroup() throws IOException {
         testPartitionByKeyGroupForSize(10, random);
     }
 
-    @SuppressWarnings("unchecked")
+    @Test

Review comment:
       I'd probably put these two (three) methods after `testPartitionByKeyGroupForSize()`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org