You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/01/21 21:25:03 UTC

[GitHub] ashb commented on a change in pull request #4292: [AIRFLOW-2508] Handle non string types in Operators templatized fields

ashb commented on a change in pull request #4292: [AIRFLOW-2508] Handle non string types in Operators templatized fields
URL: https://github.com/apache/airflow/pull/4292#discussion_r249582407
 
 

 ##########
 File path: tests/models.py
 ##########
 @@ -31,10 +31,14 @@
 import time
 import unittest
 import urllib
+import uuid
 from tempfile import NamedTemporaryFile, mkdtemp
 
 import pendulum
 import six
+from hamcrest import contains, instance_of
+from hamcrest.core import assert_that
+from hamcrest.core.core import is_
 
 Review comment:
   Please just use the built in assert methods `assertIsIn`, `assertIsInstanceOf` etc.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services