You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/07 09:37:23 UTC
[GitHub] [incubator-superset] moshthepitt opened a new pull request #8931:
Fix docstrings in superset/config.py
moshthepitt opened a new pull request #8931: Fix docstrings in superset/config.py
URL: https://github.com/apache/incubator-superset/pull/8931
### CATEGORY
Choose one
- [ ] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [x] Documentation
### SUMMARY
Fix docstrings in config.py, specifically:
- Replace ldap with LDAP
- Replace `(username/password()` with `(username/password)`
### TEST PLAN
There is no test plan because no Python code is affected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar merged pull request #8931: [docs] Fix
docstrings in superset/config.py
Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #8931: [docs] Fix docstrings in superset/config.py
URL: https://github.com/apache/incubator-superset/pull/8931
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on issue #8931: [docs] Fix
docstrings in superset/config.py
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on issue #8931: [docs] Fix docstrings in superset/config.py
URL: https://github.com/apache/incubator-superset/pull/8931#issuecomment-571539570
Thank you @moshthepitt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8931: Fix
docstrings in superset/config.py
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #8931: Fix docstrings in superset/config.py
URL: https://github.com/apache/incubator-superset/pull/8931#issuecomment-571526192
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8931?src=pr&el=h1) Report
> Merging [#8931](https://codecov.io/gh/apache/incubator-superset/pull/8931?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/93bcace20fc9c034383b520157a990d9d4bf4598?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/8931/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/8931?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8931 +/- ##
=======================================
Coverage 58.97% 58.97%
=======================================
Files 359 359
Lines 11333 11333
Branches 2787 2787
=======================================
Hits 6684 6684
Misses 4471 4471
Partials 178 178
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8931?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8931?src=pr&el=footer). Last update [93bcace...b2c3692](https://codecov.io/gh/apache/incubator-superset/pull/8931?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org