You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/02/03 15:37:41 UTC
[GitHub] [flink] matriv opened a new pull request #18622: [hotfix] Replace deprecated usages of untyped `defaultValue` and `noDefaultValue`
matriv opened a new pull request #18622:
URL: https://github.com/apache/flink/pull/18622
Add types to `ConfigOptions` and replace usages of the untyped methods
`defaultValue` and `noDefaultValue` with the corresponding typed ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on a change in pull request #18622: [FLINK-25984] Replace deprecated, untyped `defaultValue` & `noDefaultValue`
Posted by GitBox <gi...@apache.org>.
matriv commented on a change in pull request #18622:
URL: https://github.com/apache/flink/pull/18622#discussion_r801528122
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/AkkaOptions.java
##########
@@ -299,6 +300,7 @@
@Deprecated
public static final ConfigOption<String> WATCH_HEARTBEAT_PAUSE =
ConfigOptions.key("akka.watch.heartbeat.pause")
+ .stringType()
Review comment:
Opened: https://issues.apache.org/jira/browse/FLINK-26007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18622: [hotfix] Replace deprecated usages of untyped `defaultValue` and `noDefaultValue`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18622:
URL: https://github.com/apache/flink/pull/18622#issuecomment-1029125411
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d06d3f24d7afd1077750fb12df662ffefce16e7d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30709",
"triggerID" : "d06d3f24d7afd1077750fb12df662ffefce16e7d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d06d3f24d7afd1077750fb12df662ffefce16e7d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30709)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #18622: [FLINK-25984] Replace deprecated, untyped `defaultValue` & `noDefaultValue`
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #18622:
URL: https://github.com/apache/flink/pull/18622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on pull request #18622: [FLINK-25984] Replace deprecated, untyped `defaultValue` & `noDefaultValue`
Posted by GitBox <gi...@apache.org>.
matriv commented on pull request #18622:
URL: https://github.com/apache/flink/pull/18622#issuecomment-1031484238
Thx @zentol! Please check again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18622: [hotfix] Replace deprecated usages of untyped `defaultValue` and `noDefaultValue`
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18622:
URL: https://github.com/apache/flink/pull/18622#issuecomment-1029125411
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d06d3f24d7afd1077750fb12df662ffefce16e7d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d06d3f24d7afd1077750fb12df662ffefce16e7d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d06d3f24d7afd1077750fb12df662ffefce16e7d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18622: [hotfix] Replace deprecated usages of untyped `defaultValue` and `noDefaultValue`
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18622:
URL: https://github.com/apache/flink/pull/18622#issuecomment-1029121252
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit d06d3f24d7afd1077750fb12df662ffefce16e7d (Thu Feb 03 15:42:26 UTC 2022)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18622: [FLINK-25984] Replace deprecated, untyped `defaultValue` & `noDefaultValue`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18622:
URL: https://github.com/apache/flink/pull/18622#issuecomment-1029125411
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d06d3f24d7afd1077750fb12df662ffefce16e7d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30709",
"triggerID" : "d06d3f24d7afd1077750fb12df662ffefce16e7d",
"triggerType" : "PUSH"
}, {
"hash" : "36e4427a3f90de5769f25e0f47bd7de4343d8c43",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30854",
"triggerID" : "36e4427a3f90de5769f25e0f47bd7de4343d8c43",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d06d3f24d7afd1077750fb12df662ffefce16e7d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30709)
* 36e4427a3f90de5769f25e0f47bd7de4343d8c43 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30854)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18622: [FLINK-25984] Replace deprecated, untyped `defaultValue` & `noDefaultValue`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18622:
URL: https://github.com/apache/flink/pull/18622#issuecomment-1029125411
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d06d3f24d7afd1077750fb12df662ffefce16e7d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30709",
"triggerID" : "d06d3f24d7afd1077750fb12df662ffefce16e7d",
"triggerType" : "PUSH"
}, {
"hash" : "36e4427a3f90de5769f25e0f47bd7de4343d8c43",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "36e4427a3f90de5769f25e0f47bd7de4343d8c43",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d06d3f24d7afd1077750fb12df662ffefce16e7d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30709)
* 36e4427a3f90de5769f25e0f47bd7de4343d8c43 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #18622: [FLINK-25984] Replace deprecated, untyped `defaultValue` & `noDefaultValue`
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #18622:
URL: https://github.com/apache/flink/pull/18622#discussion_r801466949
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/AkkaOptions.java
##########
@@ -299,6 +300,7 @@
@Deprecated
public static final ConfigOption<String> WATCH_HEARTBEAT_PAUSE =
ConfigOptions.key("akka.watch.heartbeat.pause")
+ .stringType()
Review comment:
@matriv Did you consider to use the `durationType`? If the string format is the same and we can avoid side effects, we should definitely try to introduce the proper type for all intervals.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on a change in pull request #18622: [FLINK-25984] Replace deprecated, untyped `defaultValue` & `noDefaultValue`
Posted by GitBox <gi...@apache.org>.
matriv commented on a change in pull request #18622:
URL: https://github.com/apache/flink/pull/18622#discussion_r801478358
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/AkkaOptions.java
##########
@@ -299,6 +300,7 @@
@Deprecated
public static final ConfigOption<String> WATCH_HEARTBEAT_PAUSE =
ConfigOptions.key("akka.watch.heartbeat.pause")
+ .stringType()
Review comment:
Yep, it would, I would rather create a separate issue to track this change, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #18622: [FLINK-25984] Replace deprecated, untyped `defaultValue` & `noDefaultValue`
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #18622:
URL: https://github.com/apache/flink/pull/18622#discussion_r801479527
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/AkkaOptions.java
##########
@@ -299,6 +300,7 @@
@Deprecated
public static final ConfigOption<String> WATCH_HEARTBEAT_PAUSE =
ConfigOptions.key("akka.watch.heartbeat.pause")
+ .stringType()
Review comment:
In any case I'd say that this would be outside the scope of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18622: [hotfix] Replace deprecated usages of untyped `defaultValue` and `noDefaultValue`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18622:
URL: https://github.com/apache/flink/pull/18622#issuecomment-1029125411
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d06d3f24d7afd1077750fb12df662ffefce16e7d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30709",
"triggerID" : "d06d3f24d7afd1077750fb12df662ffefce16e7d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d06d3f24d7afd1077750fb12df662ffefce16e7d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30709)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #18622: [FLINK-25984] Replace deprecated, untyped `defaultValue` & `noDefaultValue`
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #18622:
URL: https://github.com/apache/flink/pull/18622#discussion_r801476065
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/AkkaOptions.java
##########
@@ -299,6 +300,7 @@
@Deprecated
public static final ConfigOption<String> WATCH_HEARTBEAT_PAUSE =
ConfigOptions.key("akka.watch.heartbeat.pause")
+ .stringType()
Review comment:
Wouldn't that be a breaking change for affected options?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #18622: [hotfix] Replace deprecated usages of untyped `defaultValue` and `noDefaultValue`
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #18622:
URL: https://github.com/apache/flink/pull/18622#discussion_r800600096
##########
File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/FlinkRexUtil.scala
##########
@@ -53,7 +53,8 @@ object FlinkRexUtil {
@Experimental
private[flink] val TABLE_OPTIMIZER_CNF_NODES_LIMIT: ConfigOption[Integer] =
key("table.optimizer.cnf-nodes-limit")
- .defaultValue(Integer.valueOf(-1))
+ .intType()
+ .defaultValue(Integer.valueOf(-1))
Review comment:
indentation is different than subsequent lines
##########
File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/physical/batch/BatchPhysicalSortMergeJoinRule.scala
##########
@@ -150,6 +150,7 @@ object BatchPhysicalSortMergeJoinRule {
@Experimental
val TABLE_OPTIMIZER_SMJ_REMOVE_SORT_ENABLED: ConfigOption[JBoolean] =
key("table.optimizer.smj.remove-sort-enabled")
+ .booleanType()
Review comment:
indentation is different than subsequent lines
##########
File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/metadata/FlinkRelMdRowCount.scala
##########
@@ -449,8 +449,9 @@ object FlinkRelMdRowCount {
@Experimental
val TABLE_OPTIMIZER_ROWS_PER_LOCALAGG: ConfigOption[JLong] =
key("table.optimizer.rows-per-local-agg")
+ .longType()
.defaultValue(JLong.valueOf(1000000L))
- .withDescription("Sets estimated number of records that one local-agg processes. " +
- "Optimizer will infer whether to use local/global aggregate according to it.")
+ .withDescription("Sets estimated number of records that one local-agg processes. "
+ + "Optimizer will infer whether to use local/global aggregate according to it.")
Review comment:
revert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18622: [FLINK-25984] Replace deprecated, untyped `defaultValue` & `noDefaultValue`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18622:
URL: https://github.com/apache/flink/pull/18622#issuecomment-1029125411
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d06d3f24d7afd1077750fb12df662ffefce16e7d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30709",
"triggerID" : "d06d3f24d7afd1077750fb12df662ffefce16e7d",
"triggerType" : "PUSH"
}, {
"hash" : "36e4427a3f90de5769f25e0f47bd7de4343d8c43",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30854",
"triggerID" : "36e4427a3f90de5769f25e0f47bd7de4343d8c43",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 36e4427a3f90de5769f25e0f47bd7de4343d8c43 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30854)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org