[jira] [Commented] (IMPALA-11358) Kudu tables missing comment field if HMS-Kudu integration is enabled

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-11358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556606#comment-17556606 ] 

ASF subversion and git services commented on IMPALA-11358:
----------------------------------------------------------

Commit 8965059c2c29dc2426339c1989159ec69bf6289e in impala's branch refs/heads/master from Gergely Fürnstáhl
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=8965059c2 ]

IMPALA-11358: Fixed Kudu table's missing comment

If Kudu-HMS integration is enabled, Kudu creates the table in HMS too,
which was missing the comment field. Added the code to forward the
comment field to Kudu during creation.

Testing:

Added a test to verify the comment is present when the intergration is
enabled.
Reenabled several kudu tests as IMPALA-8751 (and follow ups) fixed the
hive3 notification incompatibility.

Change-Id: Idf66f8b4679b00da6693a27fed79b04e8f6afb55
Reviewed-on: http://gerrit.cloudera.org:8080/18627
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Kudu tables missing comment field if HMS-Kudu integration is enabled
> --------------------------------------------------------------------
>
>                 Key: IMPALA-11358
>                 URL: https://issues.apache.org/jira/browse/IMPALA-11358
>             Project: IMPALA
>          Issue Type: Bug
>            Reporter: Gergely Fürnstáhl
>            Assignee: Gergely Fürnstáhl
>            Priority: Major
>
> *Reproduction:*
> Restart kudu with HMS integration enabled
> export IMPALA_KUDU_STARTUP_FLAGS=-hive_metastore_uris=thrift://localhost
> testdata/cluster/admin restart kudu
> create table kudu_test (
> col1 string comment 'col1',
> col2 string comment 'col2',
> primary key (col1)
> )
> comment 'kudu_test_comment'
> stored as kudu;
> describe formatted kudu_test;
> ...
> | |comment| |
> ...
> *Proposed solution:*
> customer found it seems due to there's setComment is missing
> [https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java#L258]
> // Set the table's owner.
> tableOpts.setOwner(msTbl.getOwner());
> // adding line
> tableOpts.setComment(params.getComment());



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org