You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/04/15 20:29:02 UTC

Review Request: Updated the Resource Monitor tests to use dispatch expectations.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10485/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Vinod Kone.


Description
-------

This is to eliminate the potential for flakiness.


Diffs
-----

  src/slave/monitor.hpp d11247faa76472fd43a77cf90adb27276bb7949e 
  src/slave/monitor.cpp b291538af55603ffd059aaf9710831d78f385292 
  src/tests/monitor_tests.cpp eb5bb73ce96ac11b76dc288834087c06964343fe 

Diff: https://reviews.apache.org/r/10485/diff/


Testing
-------

Ran thousands of iterations on OSX and Linux.


Thanks,

Ben Mahler

Re: Review Request: Updated the Resource Monitor tests to use dispatch expectations.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10485/#review19201
-----------------------------------------------------------

Ship it!



src/tests/monitor_tests.cpp
<https://reviews.apache.org/r/10485/#comment39773>

    s/UNTIL/READY



src/tests/monitor_tests.cpp
<https://reviews.apache.org/r/10485/#comment39775>

    ditto


- Vinod Kone


On April 15, 2013, 6:29 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10485/
> -----------------------------------------------------------
> 
> (Updated April 15, 2013, 6:29 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> This is to eliminate the potential for flakiness.
> 
> 
> Diffs
> -----
> 
>   src/slave/monitor.hpp d11247faa76472fd43a77cf90adb27276bb7949e 
>   src/slave/monitor.cpp b291538af55603ffd059aaf9710831d78f385292 
>   src/tests/monitor_tests.cpp eb5bb73ce96ac11b76dc288834087c06964343fe 
> 
> Diff: https://reviews.apache.org/r/10485/diff/
> 
> 
> Testing
> -------
> 
> Ran thousands of iterations on OSX and Linux.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request: Updated the Resource Monitor tests to use dispatch expectations.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10485/
-----------------------------------------------------------

(Updated April 15, 2013, 6:36 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Vinod's comments.


Description
-------

This is to eliminate the potential for flakiness.


Diffs (updated)
-----

  src/slave/monitor.hpp d11247faa76472fd43a77cf90adb27276bb7949e 
  src/slave/monitor.cpp b291538af55603ffd059aaf9710831d78f385292 
  src/tests/monitor_tests.cpp eb5bb73ce96ac11b76dc288834087c06964343fe 

Diff: https://reviews.apache.org/r/10485/diff/


Testing
-------

Ran thousands of iterations on OSX and Linux.


Thanks,

Ben Mahler