[GitHub] [incubator-doris] HappenLee commented on a change in pull request #5990: [Enhancement] Use Parallel Hash Map Replace Unordered Map In Dict Encodeing Map And Hyper Set

[GitBox <gi...@apache.org>]

HappenLee commented on a change in pull request #5990:
URL: https://github.com/apache/incubator-doris/pull/5990#discussion_r648845033



##########
File path: be/src/olap/rowset/segment_v2/binary_dict_page.h
##########
@@ -86,7 +86,7 @@ class BinaryDictPageBuilder : public PageBuilder {
         }
     };
     // query for dict item -> dict id
-    std::unordered_map<Slice, uint32_t, HashOfSlice> _dictionary;
+    phmap::flat_hash_map<Slice, uint32_t, HashOfSlice> _dictionary;

Review comment:
       yes，so it is eazily to replace the standard library




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org