You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jay Guo <gu...@cn.ibm.com> on 2016/12/05 08:47:54 UTC

Review Request 54365: Fixed indentation of a function argument in master.cpp.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54365/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler and Guangya Liu.


Repository: mesos


Description
-------

Fixed indentation of a function argument in master.cpp.


Diffs
-----

  src/master/master.cpp b0670d993348d189fafff0f83f9da0c5b18d1c51 

Diff: https://reviews.apache.org/r/54365/diff/


Testing
-------


Thanks,

Jay Guo

Re: Review Request 54365: Fixed indentation of a function argument in master.cpp.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54365/#review157977
-----------------------------------------------------------



Patch looks great!

Reviews applied: [54359, 54360, 54361, 54362, 54363, 54365]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 5, 2016, 8:48 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54365/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2016, 8:48 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Guangya Liu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed indentation of a function argument in master.cpp.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp b0670d993348d189fafff0f83f9da0c5b18d1c51 
> 
> Diff: https://reviews.apache.org/r/54365/diff/
> 
> 
> Testing
> -------
> 
> line 3902 should be aligned with other arguments.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 54365: Fixed indentation of a function argument in master.cpp.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54365/#review158174
-----------------------------------------------------------


Ship it!




Ship It!

- Guangya Liu


On \u5341\u4e8c\u6708 5, 2016, 8:48 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54365/
> -----------------------------------------------------------
> 
> (Updated \u5341\u4e8c\u6708 5, 2016, 8:48 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Guangya Liu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed indentation of a function argument in master.cpp.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp b0670d993348d189fafff0f83f9da0c5b18d1c51 
> 
> Diff: https://reviews.apache.org/r/54365/diff/
> 
> 
> Testing
> -------
> 
> line 3902 should be aligned with other arguments.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 54365: Fixed indentation of a function argument in master.cpp.

Posted by Guangya Liu <gy...@gmail.com>.

> On \u4e00\u6708 10, 2017, 7:34 a.m., Guangya Liu wrote:
> > Ship It!

I have committed this already, but seems do not have permission to close this review, will close this when got permission.

commit 653fe55b3f2e6cd76567945dbbec4a84c03f13c2
Author: Jay Guo <gu...@gmail.com>
Date:   Tue Jan 10 15:32:05 2017 +0800

    Fixed indentation of a function argument in master.cpp.

    Fixed indentation of a function argument in master.cpp.

    Review: https://reviews.apache.org/r/54365/


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54365/#review161040
-----------------------------------------------------------


On \u5341\u4e8c\u6708 9, 2016, 9:38 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54365/
> -----------------------------------------------------------
> 
> (Updated \u5341\u4e8c\u6708 9, 2016, 9:38 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Guangya Liu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed indentation of a function argument in master.cpp.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 353e6ea802e197b4456c1647f78d9984a50f1c9d 
> 
> Diff: https://reviews.apache.org/r/54365/diff/
> 
> 
> Testing
> -------
> 
> line 3902 should be aligned with other arguments.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 54365: Fixed indentation of a function argument in master.cpp.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54365/#review161040
-----------------------------------------------------------


Ship it!




Ship It!

- Guangya Liu


On \u5341\u4e8c\u6708 9, 2016, 9:38 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54365/
> -----------------------------------------------------------
> 
> (Updated \u5341\u4e8c\u6708 9, 2016, 9:38 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Guangya Liu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed indentation of a function argument in master.cpp.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 353e6ea802e197b4456c1647f78d9984a50f1c9d 
> 
> Diff: https://reviews.apache.org/r/54365/diff/
> 
> 
> Testing
> -------
> 
> line 3902 should be aligned with other arguments.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 54365: Fixed indentation of a function argument in master.cpp.

Posted by Jay Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54365/
-----------------------------------------------------------

(Updated Dec. 9, 2016, 5:38 p.m.)


Review request for mesos, Benjamin Mahler and Guangya Liu.


Repository: mesos


Description
-------

Fixed indentation of a function argument in master.cpp.


Diffs
-----

  src/master/master.cpp 353e6ea802e197b4456c1647f78d9984a50f1c9d 

Diff: https://reviews.apache.org/r/54365/diff/


Testing
-------

line 3902 should be aligned with other arguments.


Thanks,

Jay Guo

Re: Review Request 54365: Fixed indentation of a function argument in master.cpp.

Posted by Jay Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54365/
-----------------------------------------------------------

(Updated Dec. 9, 2016, 1:41 p.m.)


Review request for mesos, Benjamin Mahler and Guangya Liu.


Changes
-------

rebase


Repository: mesos


Description
-------

Fixed indentation of a function argument in master.cpp.


Diffs (updated)
-----

  src/master/master.cpp 353e6ea802e197b4456c1647f78d9984a50f1c9d 

Diff: https://reviews.apache.org/r/54365/diff/


Testing
-------

line 3902 should be aligned with other arguments.


Thanks,

Jay Guo

Re: Review Request 54365: Fixed indentation of a function argument in master.cpp.

Posted by Jay Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54365/
-----------------------------------------------------------

(Updated Dec. 8, 2016, 1:59 p.m.)


Review request for mesos, Benjamin Mahler and Guangya Liu.


Changes
-------

rebase


Repository: mesos


Description
-------

Fixed indentation of a function argument in master.cpp.


Diffs (updated)
-----

  src/master/master.cpp 353e6ea802e197b4456c1647f78d9984a50f1c9d 

Diff: https://reviews.apache.org/r/54365/diff/


Testing
-------

line 3902 should be aligned with other arguments.


Thanks,

Jay Guo

Re: Review Request 54365: Fixed indentation of a function argument in master.cpp.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54365/#review158311
-----------------------------------------------------------



Patch looks great!

Reviews applied: [54359, 54360, 54361, 54365]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 7, 2016, 4:02 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54365/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2016, 4:02 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Guangya Liu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed indentation of a function argument in master.cpp.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp b0670d993348d189fafff0f83f9da0c5b18d1c51 
> 
> Diff: https://reviews.apache.org/r/54365/diff/
> 
> 
> Testing
> -------
> 
> line 3902 should be aligned with other arguments.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 54365: Fixed indentation of a function argument in master.cpp.

Posted by Jay Guo <gu...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54365/
-----------------------------------------------------------

(Updated Dec. 7, 2016, 4:02 a.m.)


Review request for mesos, Benjamin Mahler and Guangya Liu.


Repository: mesos


Description
-------

Fixed indentation of a function argument in master.cpp.


Diffs
-----

  src/master/master.cpp b0670d993348d189fafff0f83f9da0c5b18d1c51 

Diff: https://reviews.apache.org/r/54365/diff/


Testing
-------

line 3902 should be aligned with other arguments.


Thanks,

Jay Guo

Re: Review Request 54365: Fixed indentation of a function argument in master.cpp.

Posted by Jay Guo <gu...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54365/
-----------------------------------------------------------

(Updated Dec. 5, 2016, 8:48 a.m.)


Review request for mesos, Benjamin Mahler and Guangya Liu.


Repository: mesos


Description
-------

Fixed indentation of a function argument in master.cpp.


Diffs
-----

  src/master/master.cpp b0670d993348d189fafff0f83f9da0c5b18d1c51 

Diff: https://reviews.apache.org/r/54365/diff/


Testing (updated)
-------

line 3902 should be aligned with other arguments.


Thanks,

Jay Guo