You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2018/05/10 13:02:26 UTC
svn commit: r1831336 - in
/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel:
PDAbstractContentStream.java font/PDFont.java
Author: tilman
Date: Thu May 10 13:02:26 2018
New Revision: 1831336
URL: http://svn.apache.org/viewvc?rev=1831336&view=rev
Log:
PDFBOX-4071: refactor the code in order to not assign to this loop counter from within the loop body
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDAbstractContentStream.java
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDFont.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDAbstractContentStream.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDAbstractContentStream.java?rev=1831336&r1=1831335&r2=1831336&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDAbstractContentStream.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDAbstractContentStream.java Thu May 10 13:02:26 2018
@@ -301,7 +301,8 @@ abstract class PDAbstractContentStream i
// Unicode code points to keep when subsetting
if (font.willBeSubset())
{
- for (int offset = 0; offset < text.length(); )
+ int offset = 0;
+ while (offset < text.length())
{
int codePoint = text.codePointAt(offset);
font.addToSubset(codePoint);
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDFont.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDFont.java?rev=1831336&r1=1831335&r2=1831336&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDFont.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/PDFont.java Thu May 10 13:02:26 2018
@@ -319,7 +319,8 @@ public abstract class PDFont implements
public final byte[] encode(String text) throws IOException
{
ByteArrayOutputStream out = new ByteArrayOutputStream();
- for (int offset = 0; offset < text.length(); )
+ int offset = 0;
+ while (offset < text.length())
{
int codePoint = text.codePointAt(offset);