[GitHub] williaster closed pull request #5825: [SIP-5] Remove unused function #easy-review

[GitBox <gi...@apache.org>]

williaster closed pull request #5825: [SIP-5] Remove unused function #easy-review
URL: https://github.com/apache/incubator-superset/pull/5825
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/assets/src/chart/Chart.jsx b/superset/assets/src/chart/Chart.jsx
index b93b2758bb..a9dd0ff3b7 100644
--- a/superset/assets/src/chart/Chart.jsx
+++ b/superset/assets/src/chart/Chart.jsx
@@ -170,10 +170,6 @@ class Chart extends React.PureComponent {
     this.props.actions.chartRenderingFailed(e, this.props.chartId);
   }
 
-  verboseMetricName(metric) {
-    return this.props.datasource.verbose_map[metric] || metric;
-  }
-
   renderTooltip() {
     if (this.state.tooltip) {
       return (
diff --git a/superset/assets/src/visualizations/table.js b/superset/assets/src/visualizations/table.js
index 1e09b83402..a875aad655 100644
--- a/superset/assets/src/visualizations/table.js
+++ b/superset/assets/src/visualizations/table.js
@@ -288,10 +288,6 @@ function adaptor(slice, payload) {
     orderDesc,
     pageLength: pageLength && parseInt(pageLength, 10),
     percentMetrics,
-    // Aug 22, 2018
-    // Perhaps this `tableFilter` field can be removed as there is
-    // no code left in repo to set tableFilter to true.
-    // which make `onAddFilter` will never be called as well.
     tableFilter,
     tableTimestampFormat,
     timeseriesLimitMetric,


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org