You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/10 18:55:05 UTC
[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #161: [FLINK-27141] Improve FlinkService#waitForClusterShutdown logic
gyfora commented on code in PR #161:
URL: https://github.com/apache/flink-kubernetes-operator/pull/161#discussion_r846827058
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkUtils.java:
##########
@@ -207,7 +213,10 @@ public static void waitForClusterShutdown(
if (!jobManagerRunning && !serviceRunning) {
break;
}
- LOG.info("Waiting for cluster shutdown... ({})", i);
+ // log a message waiting to shutdown Flink cluster every 5 seconds.
+ if (i % 4 == 0) {
Review Comment:
Wouldn't this actually print it every 4 seconds?
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/OperatorConfigOptions.java:
##########
@@ -70,9 +70,17 @@
.withDescription(
"The timeout for the observer to wait the flink rest client to return.");
- public static final ConfigOption<Duration> OPERATOR_CANCEL_JOB_TIMEOUT =
+ public static final ConfigOption<Duration> OPERATOR_RECONCILER_FLINK_CANCEL_JOB_TIMEOUT =
ConfigOptions.key("operator.reconciler.flink.cancel.job.timeout")
.durationType()
.defaultValue(Duration.ofMinutes(1))
- .withDescription("The timeout for the operator to cancel job.");
+ .withDescription(
+ "The timeout for the reconciler to wait for flink to cancel job.");
+
+ public static final ConfigOption<Duration> OPERATOR_RECONCILER_FLINK_SHUTDOWN_CLUSTER_TIMEOUT =
+ ConfigOptions.key("operator.reconciler.flink.shutdown.cluster.timeout")
Review Comment:
should be `operator.reconciler.flink.cluster.shutdown.timeout` instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org